Changeset 18

Timestamp:

09/27/05 17:24:53 (19 years ago)

Author:

thauvin

Message:

• add functions to store/get error

Location:

trunk/soft/ObsData

Files:

• ObsData/Archive.pm (modified) (3 diffs, 1 prop)
• t/OA-01.t (modified) (1 diff, 1 prop)

trunk/soft/ObsData/ObsData/Archive.pm

@@ -10 +10 @@
 use ObsData::Archive::Tar;
 
+my $error = {};
+
 sub new {
     my ($class, $archive, %options) = @_;
     my $beclass;
 
+    if (!$archive) {
+        seterror("No archive to read");
+        return undef;
+    }
+    if (!-r $archive) {
+        seterror("No such file or directory");
+        return undef;
+    }
     my $o;
     
@@ -61 +71 @@
     if ($dest) {
         $fname = $dest;
-        open($fh, '>', $dest) or return undef;
+        if(!open($fh, '>', $dest)) {
+            $error = $!;
+            return undef;
+        }
     } else {
         ($fh, $fname) = tempfile(
@@ -76 +89 @@
     close($fh);
     $fname
+}
+
+sub error {
+    return $error->{error};
+}
+
+sub seterror {
+    my ($package, $filename, $line) = caller;
+    $error = {
+        'package' => $package,
+        'filename' => $filename,
+        'line' => $line,
+        'error' => $_[1] || $_[0],
+    };
 }
 

trunk/soft/ObsData/t/OA-01.t

@@ -1 +1 @@
 # $Id$
 
-use Test::More tests => 6;
+use Test::More tests => 8;
 
 foreach (qw(ObsData::Archive ObsData::Archive::Compressed ObsData::Archive::Tar)) {
     use_ok($_);
-    can_ok($_, qw(ls extract));
+    can_ok($_, qw(ls extract seterror error));
 }
+
+my $oa = ObsData::Archive->new();
+ok(!$oa, "return an error on wrong call");
+ok(ObsData::Archive->error(), "Can get error");