Opened 11 years ago

Closed 7 years ago

#75 closed defect (fixed)

Inconsistency in fire module

Reported by: dsolyga Owned by: cpipsl
Priority: major Milestone: ORCHIDEE 1.9.7
Component: Biogeochemical processes Version: orchidee_1_9_6
Keywords: fire Cc:

Description

in lpj_fire.f90, the variable residue is calculated differently according DGVM or not :

       !! 5.2.3 Determine residue 
       !        The residue is litter that undergoes fire, but is not transformed into CO2
       IF (control%ok_dgvm .OR. .NOT.lpj_gap_const_mort) THEN
          residue(:) = firefrac(:,j) * struc_residual(:)
       ELSE
          residue(:) = litter(:,istructural,j,iabove) * firefrac(:,j) * &
               struc_residual(:)
       ENDIF

In once case, residue is a fraction and in the second case, residue is a quantity of litter. The first formulation was introduced in revision [186], the second one being the original one. Before, only the second formulation (which is correct) was used.

The problem is that residue is used indifferently to update the litter :

       !! 5.2.6 Residue remaining litter
       !        The rest (largest part) of the residue remains litter. Remaining 
       !        litter is the sum of this and of the litter which has not undergone a fire.
       litter(:,istructural,j,iabove) = &
            litter(:,istructural,j,iabove) * ( un - firefrac(:,j) ) + &
            residue(:) * ( un - bcfrac(:) )

That is not very homogeneous !

I propose to use the use the old formulation (before revision 186).


Change History (4)

comment:1 Changed 11 years ago by nvuilsce

  • Owner changed from somebody to cpipsl
  • Status changed from new to assigned

comment:2 Changed 11 years ago by peylin

  • Owner changed from cpipsl to pcadule

comment:3 Changed 11 years ago by peylin

  • Owner changed from pcadule to cpipsl

comment:4 Changed 7 years ago by jgipsl

  • Resolution set to fixed
  • Status changed from assigned to closed

This has been corrected at the same time as the black carbon was removed in the trunk, see commit [2668]

Note: See TracTickets for help on using tickets.