Changes between Version 92 and Version 93 of DevelopmentActivities/ORCHIDEE-DOFOCO


Ignore:
Timestamp:
2016-09-20T19:29:30+02:00 (8 years ago)
Author:
luyssaert
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • DevelopmentActivities/ORCHIDEE-DOFOCO

    v92 v93  
    1515- Revision 3710 includes an updated stomate scheme. This revision features an optional hack which takes all carbon required for autotrophic respiration from the atmosphere. It was found that this allows most PFTs to grow (mostly) normally. The relevant changes are contained in stomate_growth_fun_all.f90.   The model runs for 102 years with no crashes.  
    1616- [NOT solved] History variables BM_ALLOC_RES_c and BM_ALLOC_RES_n are written with invalid data. C and N in the reserve pools are contained in the variable RESERVE_M_c and RESERVE_M_n. 
    17 - [NOT solved] Some PFTs still have abnormalities in their long-term growth and decay patterns; After 100 simulation years, PFTs 18 and 22 (Broadleaved Summergreen Temperate age class 01, Needleleaf Evergreen Boreal age class 01) both contain a sharp spike in atm_to_bm-N. This spike should coincide with a sudden increase in indivdual tree density, but this does not seem to be the case. PFT 28 (Broadleaved Summergreen Boreal age class 03) shows jumps in mean tree diameter that coincide with sudden drops in individual tree density. This behavior is unexpected for unmanaged tree stands. See attached pdfs for data. 
     17- [NOT solved] Some PFTs still have abnormalities in their long-term growth and decay patterns; After 100 simulation years, PFTs 18 and 22 (Broadleaved Summergreen Temperate age class 01, Needleleaf Evergreen Boreal age class 01) both contain a sharp spike in atm_to_bm-N. This spike should coincide with a sudden increase in individual tree density, but this does not seem to be the case. PFT 28 (Broadleaved Summergreen Boreal age class 03) shows jumps in mean tree diameter that coincide with sudden drops in individual tree density. This behavior is unexpected for unmanaged tree stands. See attached pdfs for data. 
    1818 
    1919=== 21.07.2016 === 
     
    3333- N_support was replaced by atm_to_bm to avoid having variables that only contain one nutrient. atm_to_bm has a dimension for ::nelements. atm_to_bm is a flux and was as such accounted for in the mass balance closure 
    3434- Several print statements were suppressed. Run time is back at 70 seconds per years when compiled in dev on Curie 
    35 - [NOT solved] Runs for 7 years then crashes. 
     35- [solved] Runs for 7 years then crashes. 
    3636- Commit to share cleaner and faster code among the developers.   
    3737 
     
    3939=== 16.05.2016 === 
    4040- Revision 3442 has a more or less complete version of stomate (LCC is still missing but this routine does not affect the parameterisation of the model). 
    41 - [NOT solved] Most PFTs (except the crops) don't grow but don't die either (an issue with N-availability?) 
     41- [solved] Most PFTs (except the crops) don't grow but don't die either (an issue with N-availability?) 
    4242- The mass balance has been closed for all the activated stomate routines (for FOREST_MANAGED_FORCED = 1 or 2).  
    4343- [NOT solved] Need to test mass balance closure for FOREST_MANAGED_FORCED  = 3 (Coppice) and FOREST_MANAGED_FORCED  = 4 (Short Rotation Coppice).  
     
    5252- Revision 3398. Added forestry, litter raking and anthropogenic mortality.    
    5353- no new issues were found when testing the code.  
    54 - [NOT solved] When moving from age class 2 to age class 3 several PFTs show a sudden jump in LAI. Needs to be looked at. May be one of the variables does not get correctly reset or calculated when moving the information from one to the next PFT. It was noticed just now but, if a bug, it was probably introduced at the time the age classes were introduced. No obvious link with forestry. 
     54- [solved] When moving from age class 2 to age class 3 several PFTs show a sudden jump in LAI. Needs to be looked at. May be one of the variables does not get correctly reset or calculated when moving the information from one to the next PFT. It was noticed just now but, if a bug, it was probably introduced at the time the age classes were introduced. No obvious link with forestry. 
    5555 
    5656=== 29.04.2016 === 
     
    121121- [solved] The code crashes in stomate_growth_fun_alloc.f90 where qm_dia is calculated. All values are zero. 
    122122- [NOT solved] The code still makes use of biomass and circ_class_biomass. Both were kept because in the initial implementation the labile and reserve pool were not defined at the circumference level. While merging phenology I found my myself working on code that distributed the reserves over the circumference classes. If this is consistently done throughout stomate there is no reason to keep biomass (and ind). This would also overcome the need to sync biomass vs circ_class_biomass and ind vs circ_class_ind. 
    123 - [SOLVED] the Nitrogen version of the code makes use of Nsupport when impose_cn is TRUE. The function of the variable seems identical to atm_to_bm (which replaces co2_to_bm and n_to_bm) so Nsupport is no longer used. Confirm whether this is acceptable. 
     123- [solved] the Nitrogen version of the code makes use of Nsupport when impose_cn is TRUE. The function of the variable seems identical to atm_to_bm (which replaces co2_to_bm and n_to_bm) so Nsupport is no longer used. Confirm whether this is acceptable. 
    124124- [solved] The code for the dynamic N-cycle seems to be incomplete (the if-loop only accounts for one case for other cases variables may become undefined). This section was marked with +++CHECK+++. 
    125125