Changes between Version 6 and Version 7 of DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation

Timestamp:

2015-08-31T17:02:53+02:00 (9 years ago)

Author:

maignan

Comment:

--

DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation

@@ -100 +100 @@
 
 === '''Bugs''' ===
+* '''thermosoil.f90 / thermosoil_finalize''' (2015/08/31)
+The gtemp variable was not saved in the restart file.[[BR]]
+The following correction should be applied:
+{{{
+SUBROUTINE thermosoil_finalize(kjit, kjpindex, rest_id, temp_sol_new, gtemp, soilcap, soilflx)          !@FM_150831
+    !! 0. Variable and parameter declaration 
+    !! 0.1 Input variables 
+    INTEGER(i_std), INTENT(in)                            :: kjit             !! Time step number (unitless)  
+    INTEGER(i_std), INTENT(in)                            :: kjpindex         !! Domain size (unitless) 
+    INTEGER(i_std),INTENT (in)                            :: rest_id          !! Restart file identifier(unitless) 
+    REAL(r_std),DIMENSION (kjpindex), INTENT (in)         :: temp_sol_new     !! Surface temperature at the present time-step, 
+    REAL(r_std),DIMENSION (kjpindex),INTENT(in)           :: gtemp            !! First soil layer temperature   !@FM_150831
+...
+        var_name= 'temp_sol_beg'
+        CALL restput_p(rest_id, var_name, nbp_glo, 1, 1, kjit, temp_sol_beg, 'scatter', nbp_glo, index_g)
+
+        CALL restput_p(rest_id, 'gtemp', nbp_glo, 1, 1, kjit, gtemp, 'scatter', nbp_glo, index_g)       !@FM_150831
+...
+}}}
+
+with the corresponding call in sechiba_finalize:
+
+{{{
+    !! 5. Call soil thermodynamic to write restart files
+!@FM_150831    CALL thermosoil_finalize(kjit, kjpindex, rest_id, temp_sol_new, soilcap, soilflx)
+    CALL thermosoil_finalize(kjit, kjpindex, rest_id, temp_sol_new, gtemp, soilcap, soilflx)            !@FM_150831
+}}}
+
+The MICT thermosoil_finalize is different from the Trunk version so probably other variables have to be checked.
 
 * '''stomate.f90 / call writerestart''' (2015/08/27)