wiki:DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation

Version 1 (modified by maignan, 9 years ago) (diff)

--

Evaluation

Notes from F. Maignan

2015/08/21

I've started a 2 degree V6 evaluation here: /home/surface3/maignan/ORCHIDEE/TESTS/test_MICT_V6/modipsl/modeles/ORCHIDEE/modipsl/config/ORCHIDEE_OL/OOL_SEC_STO_V6

The modified code is in /home/surface3/maignan/ORCHIDEE/TESTS/test_MICT_V6/modipsl

  • Bugs
    • stomate_Cforcing_name and stomate_forcing_name

I've found a problem with the variable Cforcing_name, which is declared both as a global save variable of the stomate module and as a save variable of the stomate_main procedure. It is read in stomate_initialize using a getin_p but indeed the value is not correctly transmitted to the stomate_main procedure. There is also a stomate_Cforcing_name in constantes_var.

I corrected this using the constantes_var variable stomate_Cforcing_name and suppressing the two other Cforcing_name in the stomate module.

Then I did the same for forcing_name.

I don't know where this weird code originates from, I hope it's OK with forcesoil and teststomate, I'll check later.

  • To be corrected
    • GRAZING_MAP should not be read if grassland management is not activated.
    • If OK_EXPLICITSNOW is FALSE then snowdz is not initialized but used anyway (this is probably the case of other variables, to be checked).