Changeset 446

Timestamp:

06/29/12 14:53:43 (12 years ago)

Author:

grenoya

Message:

• create listlc to have the same behavior as list but returns lowercase
• factorisation of list and listlc -> creation of listQuery

File:

• server/trunk/web/lib/Sophie/Controller/Chat/Cmd.pm (modified) (3 diffs)

server/trunk/web/lib/Sophie/Controller/Chat/Cmd.pm

@@ -392 +392 @@
     my ($self, $c, $reqspec, @args) = @_;
 
-    my $distrib = {
-        distribution => $args[0],
-        release      => $args[1],
-        arch         => $args[2],
-    };
-
-    if (!$c->forward('/distrib/exists', [ $distrib ])) {
+    my $list = $c->forward('_listQuery' , [ @args ]);
+
+    if (!@$list) { 
         return $c->stash->{xmlrpc} = {
             message => [ "I don't have any distribution matching: "
@@ -405 +401 @@
     }
 
-    my @list = @{ $c->forward('/distrib/list', [ $distrib ]) };
     return $c->stash->{xmlrpc} = {
         message => [ 
@@ -412 +407 @@
                 : '') .
             join(', ', @list) ],
+    }
+}
+
+#=head2 _listlc [distribution [release [arch]]]
+#
+#List available distribution, release, architecture matching given arguments, in
+#lower case.
+#
+#=cut
+
+sub _listlc : private {
+    my ($self, $c, $reqspec, @args) = @_;
+
+    # call for the common list query
+    my $list = $c->forward('_listQuery' , [ @args ]);
+
+    # lowercase of the list and return
+    return [ map( lc, @{ $list || [] } ) ];
+}
+
+=head2 _listQuery [distribution [release [arch]]]
+
+#List available distribution, release, architecture matching given arguments.
+
+=cut
+
+sub _listQuery : Private {
+    my ($self, $c, $reqspec, @args) = @_;
+
+    my $distrib = {
+        distribution => $args[0],
+        release      => $args[1],
+        arch         => $args[2],
+    };
+
+    if (!$c->forward('/distrib/exists', [ $distrib ])) {
+        return [];
+    }
+
+    return @{ $c->forward('/distrib/list', [ $distrib ]) };
     }
 }