Opened 5 years ago

Closed 5 years ago

#89 closed defect (invalid)

Error in node/domain.cpp on ChecKDomainData

Reported by: ssenesi Owned by: ymipsl
Priority: trivial Component: XIOS
Version: 2.0 Keywords: data_dim, data_ni, domain
Cc:

Description

It reads on line 792 as

      if (data_ni.isEmpty())
      {
        data_ni.setValue((data_dim == 1) ? (ni.getValue() * nj.getValue()) : ni.getValue());
      }

which is obviously wrong (set values should be reversed). This actually causes segmentation violation when nj is not set and data_dim==1; and this should lead to underestimated allocation when data_dim==2

Change History (3)

comment:1 Changed 5 years ago by ssenesi

The same applies to data_nj a few lines further below

comment:2 Changed 5 years ago by ssenesi

Thinking twice, the values are not wrong, except that some default initialization of 'nj' to value '1' should occur upstream.

comment:3 Changed 5 years ago by mhnguyen

  • Keywords data_dim data_ni domain added
  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.