Changeset 12783

Timestamp:

2020-04-20T20:19:21+02:00 (3 years ago)

Author:

rrenshaw

Message:

bug fixes for profiles from ​https://code.metoffice.gov.uk/trac/utils/ticket/335

Location:

branches/UKMO/dev_r5518_obs_oper_update_reanalysis4/NEMOGCM/NEMO/OPA_SRC/OBS

Files:

• obs_level_search.h90 (modified) (3 diffs)
• obs_prep.F90 (modified) (8 diffs)

branches/UKMO/dev_r5518_obs_oper_update_reanalysis4/NEMOGCM/NEMO/OPA_SRC/OBS/obs_level_search.h90

@@ -13 +13 @@
       !! ** Method  : Straightforward search
       !!
-      !! ** Action  : 
+      !! ** Action  : Will return level associated with T-point below the obs
+      !!              depth, except when observation is in the top box will
+      !!              return level 2. Also, if obs depth greater than depth
+      !!              of last wet T-point (kpk-1) will return level kpk.
       !!
       !! History :
@@ -21 +24 @@
       !!        !  2006-10  (A. Weaver) Cleanup
       !!        !  2008-10  (K. Mogensen) Remove assumptions on grid.
+      !!        !  2020-04  (R. King/RJR) Add Rob's fix
+      !!        !            https://code.metoffice.gov.uk/trac/utils/ticket/335
       !!----------------------------------------------------------------------
 
@@ -43 +48 @@
       DO ji = 1, kobs 
          kobsk(ji) = 1
-         depk: DO jk = 2, kgrd
+         depk: DO jk = 2, kgrd-1
             IF ( pgrddep(jk) >= pobsdep(ji) ) EXIT depk
          END DO depk

branches/UKMO/dev_r5518_obs_oper_update_reanalysis4/NEMOGCM/NEMO/OPA_SRC/OBS/obs_prep.F90

@@ -16 +16 @@
    USE par_kind, ONLY : & ! Precision variables
       & wp   
+   USE dom_oce            ! ocean space and time domain
    USE in_out_manager     ! I/O manager
    USE obs_profiles_def   ! Definitions for storage arrays for profiles
@@ -1100 +1101 @@
       !!        !  2007-01  (K. Mogensen) Rewrite of parts of obs_scr
       !!        !  2007-06  (K. Mogensen et al) Reject obs. near land.
+      !!        !  2020-04  (R. King/RJR) Add Rob's fix
+      !!        !            https://code.metoffice.gov.uk/trac/utils/ticket/335
       !!----------------------------------------------------------------------
       !! * Modules used
@@ -1163 +1166 @@
       REAL(KIND=wp), DIMENSION(2,2,kprofno) :: &
          & zglam, &           ! Model longitude at grid points
-         & zgphi              ! Model latitude at grid points
+         & zgphi, &           ! Model latitude at grid points
+         & zbathy             ! Index of deepest wet level at grid points
       INTEGER, DIMENSION(2,2,kprofno) :: &
          & igrdi, &           ! Grid i,j
@@ -1171 +1175 @@
       INTEGER :: iig, ijg           ! i,j of observation on model grid point.
       INTEGER :: jobs, jobsp, jk, ji, jj
+      REAL(KIND=wp) :: maxdept, maxdepw
 
       ! Get grid point indices
@@ -1221 +1226 @@
       CALL obs_int_comm_2d( 2, 2, kprofno, kpi, kpj, igrdi, igrdj, plam, zglam )
       CALL obs_int_comm_2d( 2, 2, kprofno, kpi, kpj, igrdi, igrdj, pphi, zgphi )
+      CALL obs_int_comm_2d( 2, 2, kprofno, kpi, kpj, igrdi, igrdj, REAL(mbathy), zbathy )
       ! Need to know the bathy depth for each observation for sco
       CALL obs_int_comm_3d( 2, 2, kprofno, kpi, kpj, kpk, igrdi, igrdj, fsdepw(:,:,:), &
@@ -1261 +1267 @@
          DO jobsp = kpstart(jobs), kpend(jobs)
 
+            ! Calculate max T and W depths of 2x2 grid
+            maxdept=zgdept(1,1,NINT(zbathy(1,1,jobs)),jobs)
+            maxdepw=zgdepw(1,1,NINT(zbathy(1,1,jobs))+1,jobs)
+            DO jj = 1, 2
+               DO ji = 1, 2
+                  IF ( zgdept(ji,jj,NINT(zbathy(ji,jj,jobs)),jobs) > maxdept ) THEN
+                     maxdept = zgdept(ji,jj,NINT(zbathy(ji,jj,jobs)),jobs)
+                  END IF
+                  IF ( zgdepw(ji,jj,NINT(zbathy(ji,jj,jobs))+1,jobs) > maxdepw ) THEN
+                     maxdepw = zgdepw(ji,jj,NINT(zbathy(ji,jj,jobs))+1,jobs)
+                  END IF
+               END DO
+            END DO
+
             ! Flag if the observation falls outside the model spatial domain
             IF (       ( pobslam(jobs) < -180.         )       &
@@ -1267 +1287 @@
                &  .OR. ( pobsphi(jobs) >   90.         )       &
                &  .OR. ( pobsdep(jobsp) < 0.0          )       &
-               &  .OR. ( pobsdep(jobsp) > gdepw_1d(kpk)) ) THEN
+               &  .OR. ( pobsdep(jobsp) >= maxdepw) ) THEN
                kobsqc(jobsp) = IBSET(kobsqc(jobsp),11)
                kosdobs = kosdobs + 1
@@ -1334 +1354 @@
                pobsdep(jobsp) = MINVAL(zgdept(1:2,1:2,1,jobs))
             ENDIF
+
+            ! Set observation depth equal to that of the last wet T-point
+            IF ( ( pobsdep(jobsp) > maxdept ) .AND. &
+               & ( pobsdep(jobsp) < maxdepw ) ) THEN
+               pobsdep(jobsp) = maxdept
+            ENDIF
             
 #if defined key_bdy