Changeset 7701

Timestamp:

2017-02-20T11:07:50+01:00 (8 years ago)

Author:

frrh

Message:

Improve control of numstr unit.

In addition to only producing output, and doing the
related global sums when we really need them, we
need to restrict it to one instance on the master PE
in all circumstances and to explicitly close it at the
end of the run. (Currently if lwp = true you get a separate
file for every PE containing identical information and none
of the tracer.stat files are explicitly closed.)

Location:

branches/UKMO/dev_r5518_MEDUSA_optim_RH/NEMOGCM/NEMO

Files:

• OPA_SRC/nemogcm.F90 (modified) (2 diffs)
• TOP_SRC/trc.F90 (modified) (1 diff)
• TOP_SRC/trcini.F90 (modified) (1 diff)
• TOP_SRC/trcstp.F90 (modified) (2 diffs)

branches/UKMO/dev_r5518_MEDUSA_optim_RH/NEMOGCM/NEMO/OPA_SRC/nemogcm.F90

@@ -74 +74 @@
 #if defined key_top
    USE trcini          ! passive tracer initialisation
+   USE trc, ONLY: numstr  ! tracer stats unit number
 #endif
    USE lib_mpp         ! distributed memory computing
@@ -596 +597 @@
       IF( numdct_heat     /= -1 )   CLOSE( numdct_heat     )   ! heat transports
       IF( numdct_salt     /= -1 )   CLOSE( numdct_salt     )   ! salt transports
+      IF( numstr          /= -1 )   CLOSE( numstr          )   ! tracer statistics
 
       !

branches/UKMO/dev_r5518_MEDUSA_optim_RH/NEMOGCM/NEMO/TOP_SRC/trc.F90

@@ -26 +26 @@
    INTEGER, PUBLIC                                                 ::   numnat_cfg = -1   !: logical unit for the reference passive tracer namelist_top_cfg
    INTEGER, PUBLIC                                                 ::   numont     = -1   !: logical unit for the reference passive tracer namelist output output.namelist.top
-   INTEGER, PUBLIC                                                 ::   numstr        !: logical unit for tracer statistics
+   INTEGER, PUBLIC                                                 ::   numstr     = -1   !: logical unit for tracer statistics
    INTEGER, PUBLIC                                                 ::   numrtr        !: logical unit for trc restart (read )
    INTEGER, PUBLIC                                                 ::   numrtw        !: logical unit for trc restart ( write )

branches/UKMO/dev_r5518_MEDUSA_optim_RH/NEMOGCM/NEMO/TOP_SRC/trcini.F90

@@ -123 +123 @@
 # endif
 
-      IF( lwp ) THEN
+      IF( ln_ctl ) THEN
          !
-         CALL ctl_opn( numstr, 'tracer.stat', 'REPLACE', 'FORMATTED', 'SEQUENTIAL', -1, numout, lwp , narea )
+         IF (narea == 1) THEN 
+            ! The tracer.stat file only contains global tracer sum values, if
+            ! it contains anything at all. Hence it only needs to be opened
+            ! and written to on the master PE, not on all PEs. 
+            CALL ctl_opn( numstr, 'tracer.stat', 'REPLACE', 'FORMATTED',  &
+                          'SEQUENTIAL', -1, numout, lwp , narea )
+         ENDIF 
          !
       ENDIF

branches/UKMO/dev_r5518_MEDUSA_optim_RH/NEMOGCM/NEMO/TOP_SRC/trcstp.F90

@@ -55 +55 @@
       !!              Update the passive tracers
       !!-------------------------------------------------------------------
+
+      USE dom_oce, ONLY: narea 
+
       INTEGER, INTENT( in ) ::  kt      ! ocean time-step index
       INTEGER               ::  jk, jn  ! dummy loop indices
@@ -136 +139 @@
          ! Hence we restrict its use by protecting it with the ln_ctl RTL
          ! which should normally only be used under debugging conditions
-         ! and not in operational runs. 
-         ztrai = 0._wp                                                   !  content of all tracers
+         ! and not in operational runs. We also need to restrict output 
+         ! to the master PE since there's no point duplicating the same results
+         ! on all processors.    
+         ztrai = 0._wp                                !  content of all tracers
          DO jn = 1, jptra
             ztrai = ztrai + glob_sum( trn(:,:,:,jn) * cvol(:,:,:)   )
          END DO
-         IF( lwp ) WRITE(numstr,9300) kt,  ztrai / areatot
+         IF (narea == 1) WRITE(numstr,9300) kt,  ztrai / areatot
 9300     FORMAT(i10,e18.10)
       ENDIF