Opened 9 years ago

Closed 8 years ago

Last modified 5 years ago

#1059 closed Bug (fixed)

Wrong scale factors with key_vvl in dynspg_flt.F90 and bdydyn.F90

Reported by: jchanut Owned by: jchanut
Priority: low Milestone:
Component: OCE Version: trunk
Severity: Keywords: BDY DYN VVL
Cc: Branch review:
MP ready?: Task progress:

Description

With key_vvl only:

  • In dynspg_flt.F90, next transport is computed with now vertical scale factors so that:
spgu(ji,jj) = spgu(ji,jj) + fse3u(ji,jj,jk) * ua(ji,jj,jk)

spgv(ji,jj) = spgv(ji,jj) + fse3v(ji,jj,jk) * va(ji,jj,jk)

it should rather be:

spgu(ji,jj) = spgu(ji,jj) + fse3u_a(ji,jj,jk) * ua(ji,jj,jk)

spgv(ji,jj) = spgv(ji,jj) + fse3v_a(ji,jj,jk) * va(ji,jj,jk)
  • In bdydyn.F90:

Barotropic velocity is computed (then removed) from ua/va arrays again with "now" vertical scale factors:

pu2d(:,:) = pu2d(:,:) + fse3u(:,:,jk) * umask(:,:,jk) * ua(:,:,jk)
pv2d(:,:) = pv2d(:,:) + fse3v(:,:,jk) * vmask(:,:,jk) * va(:,:,jk)
...
pu2d(:,:) = pu2d(:,:) * phur(:,:)
pv2d(:,:) = pv2d(:,:) * phvr(:,:)

again fse3u_a/fse3v_a arrays should be used, as well as inverse depths at next time step.

Commit History (2)

ChangesetAuthorTimeChangeLog
4010cbricaud2013-09-04T11:12:18+02:00

Fix minor bug with key_vvl. See ticket #1059

3968cbricaud2013-07-10T16:38:12+02:00

use after vertical scale factors in vvl case, see ticket #1059

Change History (8)

comment:1 Changed 9 years ago by clevy

  • Owner changed from NEMO team to jchanut

comment:2 Changed 9 years ago by jchanut

Filtered free surface: Note that depths (hu(:,:), hv(:,:)) in solmat.F90 also have to be changed accordingly to hold "after" values.

comment:3 Changed 8 years ago by jchanut

  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from nemo_v3_4 to trunk

Changes done in dynspg_flt.F90 and bdydyn.F90.
The need for changing depths in solmat.F90 was a bit unclear. We have finally let them unchanged (so given at "now" time step), sticking with Roullet and Madec (2000), equation 22c.

comment:4 Changed 5 years ago by nicolasmartin

  • Keywords BDY added; bdy removed

comment:5 Changed 5 years ago by nicolasmartin

  • Keywords VVL added; vvl removed

comment:6 Changed 5 years ago by nicolasmartin

  • Keywords dynspg_* added; dynspg_flt removed

comment:7 Changed 5 years ago by nicolasmartin

  • Keywords dynspg added; dynspg_* removed

comment:8 Changed 5 years ago by nicolasmartin

  • Keywords DYN added; dynspg removed
Note: See TracTickets for help on using tickets.