Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#1098 closed Bug (fixed)


Reported by: detraceyb Owned by: nemo
Priority: lowest Milestone:
Component: OCE Version: release-3.5
Severity: Keywords: DOM
Cc: Branch review:
MP ready?: Task progress:


Near the end of SUBROUTINE s_sf12, there are several calls to lbc_lnk. I think these calls are redundant as they are made in SUBROUTINE zgr_sco just after it calls s_sf12. (If they are required in s_sf12, then the argument 1. should be recast as 1._wp)

Other lines where reals need recasting as type wp:

REAL(jpkm1) instead of REAL(jpkm1,wp):

Commit History (0)

(No commits)

Change History (4)

comment:1 Changed 8 years ago by rfurner

  • Resolution set to fixed
  • Status changed from new to closed

These calls were unnecessary, and so have been removed.  The precision has also been corrected on the lines notes above.

The fixes were tested on the AMM12 model, running for 10 days.  the code built and ran fine, gave sensible looking output and solver.stat gave identical output as before.

comment:2 Changed 5 years ago by nicolasmartin

  • Keywords DOM added; dom removed

comment:3 Changed 5 years ago by nicolasmartin

  • Keywords domzgr removed

comment:4 Changed 5 years ago by nicolasmartin

  • Keywords s_sf12 removed
Note: See TracTickets for help on using tickets.