New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1111 (error in the conv of AGRIF) – NEMO

Opened 11 years ago

Closed 11 years ago

#1111 closed Bug (fixed)

error in the conv of AGRIF

Reported by: smasson Owned by: nemo
Priority: high Milestone:
Component: AGRIF Version: v3.4
Severity: Keywords:
Cc:

Description

From Jerome Chanut:
local variable named ztab are not seen as local variable by the conv...
for example the following piece of code:

      IF (MOD(nbcline,nbclineupdate) == 0) THEN
         CALL Agrif_Update_Variable(ztab,tsn_id, procname=updateTS)
      ELSE
         CALL Agrif_Update_Variable(ztab,tsn_id,locupdate=(/0,2/), procname=updateTS)
      ENDIF


is converted into

      IF (MOD(nbcline,nbclineupdate) == 0) THEN
         CALL Agrif_Update_Variable( 72, 171, procname=updateTS)
      ELSE
         CALL Agrif_Update_Variable( 72, 171,locupdate=(/0,2/), procname=updateTS)
      ENDIF

instead of 

      IF (MOD(nbcline,nbclineupdate) == 0) THEN
         CALL Agrif_Update_Variable(ztab, 171, procname=updateTS)
      ELSE
         CALL Agrif_Update_Variable(ztab, 171,locupdate=(/0,2/), procname=updateTS)
      ENDIF

Solution (before a bufix in the conv): rename ztab (for example into ztab4d)

      IF (MOD(nbcline,nbclineupdate) == 0) THEN
         CALL Agrif_Update_Variable(ztab4d, 171, procname=updateTS)
      ELSE
         CALL Agrif_Update_Variable(ztab4d, 171,locupdate=(/0,2/), procname=updateTS)
      ENDIF

Commit History (4)

ChangesetAuthorTimeChangeLog
3919smasson2013-06-13T12:52:53+02:00

v3_4_STABLE: better fortran and error in the conv of agrif, see ticket #1111 and #1112

3918smasson2013-06-13T12:50:37+02:00

trunk: better fortran and error in the conv of agrif, see ticket #1111 and #1112

3917smasson2013-06-12T23:04:27+02:00

v3_4_STABLE: (kind of) bugfix in agrif, see tricket #1111

3916smasson2013-06-12T23:03:47+02:00

trunk: (kind of) bugfix in agrif, see tricket #1111

Change History (4)

comment:1 Changed 11 years ago by smasson

  • Resolution set to fixed
  • Status changed from new to closed

done for the trunk, see changeset t3916
done for the v3_4_STABLE, see changeset t3917

comment:2 Changed 11 years ago by rblod

  • Resolution fixed deleted
  • Status changed from closed to reopened

I think the "true" correction is to change ztab in lib_mpp, as reported by Arthur in #1112 ... Rachid

comment:3 Changed 11 years ago by smasson

Yes.

comment:4 Changed 11 years ago by smasson

  • Resolution set to fixed
  • Status changed from reopened to closed

removed changes done in changeset r3916 abd r3917 and solve the problem by solving ticket #1112, see changeset r 3918 for the trunk and r3919 for v3_4_STABLE

Note: See TracTickets for help on using tickets.