Opened 10 years ago
Closed 7 years ago
#1137 closed Bug (wontfix)
Pb sbc_cpl_ice_tau wind stress on ice in "mixed oce-ice" coupling case
| Reported by: | aclsce | Owned by: | smasson |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | OCE | Version: | trunk |
| Severity: | Keywords: | SBC ice stress wind | |
| Cc: |
Description
It seems the bug fix #1110 introduces a problem in the use of srcv(jpr_itx1)%laction in sbc_cpl_ice_tau.
In case of "mixed oce-ice" wind stress coupling, srcv(jpr_itx1)%laction is now true (because of #1110 and that means ice stress from atmosphere is required and used ( as ice stress field) instead of ocean stress in case of "mixed oce-ice".
Since no ice stress is received in "mixed oce-ice", ice stress is still 0.
I suggest to add condition on coupling case to allows to be in the "ELSE ! use ocean stress" in "mixed oce-ice" case , as follows :
Index: sbccpl.F90
===================================================================
--- sbccpl.F90 (revision 3940)
+++ sbccpl.F90 (working copy)
@@ -930,7 +930,7 @@
!
CALL wrk_alloc( jpi,jpj, ztx, zty )
- IF( srcv(jpr_itx1)%laction ) THEN ; itx = jpr_itx1
+ IF( srcv(jpr_itx1)%laction .AND. TRIM( sn_rcv_tau%cldes ) == 'oce and ice') THEN ; itx = jpr_itx1
ELSE ; itx = jpr_otx1
ENDIF
@@ -938,7 +938,7 @@
IF( nrcvinfo(itx) == OASIS_Rcv ) THEN
! ! ======================= !
- IF( srcv(jpr_itx1)%laction ) THEN ! ice stress received !
+ IF( srcv(jpr_itx1)%laction .AND. TRIM( sn_rcv_tau%cldes ) == 'oce and ice') THEN ! ice stress received !
! ! ======================= !
Commit History (2)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 4067 | smasson | 2013-10-16T16:44:36+02:00 | dev_v3_4_STABLE_2012: bugfix for mixed oce-ice coupling, see #1110 and #1137 |
| 4066 | smasson | 2013-10-16T16:41:12+02:00 | trunk: bugfix for mixed oce-ice coupling, see #1110 and #1137 |
Change History (6)
comment:1 Changed 10 years ago by clevy
- Owner changed from NEMO team to smasson
comment:2 Changed 10 years ago by smasson
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 10 years ago by charris
- Resolution fixed deleted
- Status changed from closed to reopened
I think those allocations (the two new ones relating to this ticket and also the taum one) at the end of of sbc_cpl_init are incorrectly using 'jn' instead of the jpr pointers for the individual fields. In practice this probably won't cause a problem to anyone at the moment because these are presumably all single category fields, but it should still be corrected.
If someone indicates agreement I will do it later this week.
comment:4 Changed 7 years ago by nicolasmartin
- Milestone 2012 Stream 1: User Interfaces deleted
Milestone 2012 Stream 1: User Interfaces deleted
comment:5 Changed 7 years ago by nicolasmartin
- Keywords SBC added; sbccpl removed
comment:6 Changed 7 years ago by clevy
- Resolution set to wontfix
- Status changed from reopened to closed
Suppressing tickets opened on the trunk since more than 2 years... cleaning started!
OK. instead of adding patches of patches, I removed the modifications done for #1110 and I allocate jpr_itx1/jpr_ity1 arrays if we have a sea-ice model and if they are not already allocated.
done for trunk in changeset r4066
done for dev_v3_4_STABLE_2012 in changeset r4067