Opened 10 years ago
Closed 10 years ago
#1326 closed Bug (wontfix)
weird loop in tra_npc
| Reported by: | avidard | Owned by: | nemo |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | OCE | Version: | trunk |
| Severity: | Keywords: | ||
| Cc: |
Description
In tranpc, there is something that does not seem right:
DO jk = 1, jpkm1
DO ji = 1, jpi
zwx(ji,jk) = 1.
IF( zwx(ji,jk) < 1.e-5 ) zwx(ji,jk) = 0.e0
END DO
END DO
The condition in the IF statement is not very likely to happen. My quess is that the first statement should not be there.
I saw it on 3.4.1, but it seems that it is still around.
Commit History (3)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 4830 | gm | 2014-11-06T11:56:42+01:00 | #1092 and #1326 : new npc algorithm : small bug fix on unintialized logical |
| 4678 | gm | 2014-06-20T11:13:15+02:00 | #1092 and #1326 : npc algorithm is not working, prevent the use of npc in v3.4 stable |
| 4677 | gm | 2014-06-20T11:11:11+02:00 | #1092 and #1326 : npc algorithm is not working, prevent the use of npc in v3.6 |
Change History (1)
comment:1 Changed 10 years ago by gm
- Resolution set to wontfix
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
You are indeed right ! Nevertheless, even when fixing this bug, the current version of npc algorithm is not working properly. The ticket of Rachel (#1092) is still true.
Instead of correcting the current algorithm, which is of limited interest when using a non linear equation of state as it works on static stability computed at z=0, we develop a new version of npc that will be available in the next release (see #1294).
The new version is deeply linked to the new equation of state (see #1294), therefore it will only be available in NEMO v3.7 (see the branch 2014/dev_CNRS1_10_TEOS10_Ediag )
zdfini.F90 has been modified to prevent the use of npc algorithm in both the truc and the v3.4_stable (revision 4677 and 4678)
Gurvan