control for asm or z-tilde

[rblod]

I just had a quick look so I may be wrong but it seems than application of the increment in step is controlled by namelist values (nam_asminc) whereas this namelist block is read only with key_asminc. It leads to random behavior in my case (Agrif).
Same story with the use of thickness diffusion in sshwzw and traadv (at least) controlled by boolean read only in vvl case.

[acc]

In the tilde/vvl case this seems to be a result of removing the default values for name list variables from the code. The simplest solution would be to reintroduce them in domvvl.F90, i.e:

   LOGICAL , PUBLIC                                      :: ln_vvl_ztilde             ! ztilde vertical coordinate
   LOGICAL , PUBLIC                                      :: ln_vvl_layer              

becomes

   LOGICAL , PUBLIC                                      :: ln_vvl_ztilde  = .FALSE.          ! ztilde vertical coordinate
   LOGICAL , PUBLIC                                      :: ln_vvl_layer   = .FALSE.           

or if this isn't acceptable then set them explicitly in domain.F90, i.e.:

      IF( lk_vvl )           CALL dom_vvl_init ! Vertical variable mesh

becomes

      IF( lk_vvl )  THEN
         CALL dom_vvl_init                     ! Vertical variable mesh
      ELSE
         ln_vvl_ztilde = .FALSE.   ;   ln_vvl_layer  = .FALSE.
      ENDIF

[mocavero]

I'm investigating this.

[mocavero]

Introduction into the code of the namelist variables default values for both the assimilation increment (asminc.f90) and the vertical coordinates (domvvl.F90).