compiler error (shape pb) in diaar5.F90 after isf changes

[clevy]

NEMO_OPA_SRC/DIA/diaar5.F90 does not compile anymore after isf latest changes:

mpif90 -c -cpp -o diaar5.o -I/ccc/work/cont003/gen0826/clevy/OR1L3_FORCED_rev5120/modipsl/modeles/NEMOGCM/CONFIG/O1LPR5120/BLD/inc -i4 -[changeset:8 r8] -O3 -fp-model precise -I/ccc/work/cont003/gen0826/clevy/XIOS/inc -I/ccc/work/cont003/gen0826/clevy/now/models/oa3mct/build/lib/mct -I/ccc/work/cont003/gen0826/clevy/now/models/oa3mct/build/lib/psmile.MPI1 -I/usr/local/netcdf-4.2_hdf5_parallel/include -c /ccc/work/cont003/gen0826/clevy/OR1L3_FORCED_rev5120/modipsl/modeles/NEMOGCM/CONFIG/O1LPR5120/BLD/ppsrc/nemo/diaar5.f90
ifort: command line warning #10212: -fp-model precise evaluates in source precision with Fortran.
ifort: command line warning #10212: -fp-model precise evaluates in source precision with Fortran.
/ccc/work/cont003/gen0826/clevy/OR1L3_FORCED_rev5120/modipsl/modeles/NEMOGCM/CONFIG/O1LPR5120/BLD/ppsrc/nemo/diaar5.f90(201): error #6366: The shapes of the array expressions do not conform.   [ZTEMP]

  ztemp = ztemp + zarea_ssh(:,:) * tsn(:,:,1,jp_tem)

----
/ccc/work/cont003/gen0826/clevy/OR1L3_FORCED_rev5120/modipsl/modeles/NEMOGCM/CONFIG/O1LPR5120/BLD/ppsrc/nemo/diaar5.f90(202): error #6366: The shapes of the array expressions do not conform.   [ZSAL]

  zsal  = zsal  + zarea_ssh(:,:) * tsn(:,:,1,jp_sal)

----
compilation aborted

It is in the loop starting line 164

Proposed change (putting back explicit indexes ji and jj):

IF( .NOT.lk_vvl ) THEN

  IF ( ln_isfcav ) THEN
    DO ji=1,jpi
      DO jj=1,jpj
        ztemp = ztemp + zarea_ssh(ji,jj) * tsn(ji,jj,mikt(ji,jj),jp_tem) zsal  = zsal  + zarea_ssh(ji,jj) * tsn(ji,jj,mikt(ji,jj),jp_sal)
      END DO
    END DO
  ELSE
    ztemp = ztemp + zarea_ssh(ji,jj) * tsn(ji,jj,1,jp_tem) zsal  = zsal  + zarea_ssh(ji,jj) * tsn(ji,jj,1,jp_sal)
  END IF

ENDIF

It does compile with this change, but advice of isf experts is required before commit.
Thanks

[mathiot]

Your suggested change is not adapted. You need to do a sum overall the cells.
My suggestion is to do this (as before the merge in december for the ln_isfcav = false case) :

        IF ( ln_isfcav ) THEN
            DO ji=1,jpi
               DO jj=1,jpj
                  ztemp = ztemp + zarea_ssh(ji,jj) * tsn(ji,jj,mikt(ji,jj),jp_tem)
                  zsal  = zsal  + zarea_ssh(ji,jj) * tsn(ji,jj,mikt(ji,jj),jp_sal)
               END DO
            END DO
         ELSE
            ztemp = ztemp + SUM( zarea_ssh(:,:) * tsn(:,:,1,jp_tem) )
            zsal  = zsal  + SUM( zarea_ssh(:,:) * tsn(:,:,1,jp_sal) )
         END IF

It compiles with key_diaar5 with this change.

[acc]

Solution committed to revision 5121. Ticket closed.