New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1558 (cla_init called twice) – NEMO

Opened 8 years ago

Closed 6 years ago

#1558 closed Defect (fixed)

cla_init called twice

Reported by: dupontf Owned by: nemo
Priority: low Milestone:
Component: OCE Version: v3.6
Severity: Keywords:
Cc:

Description

We found that in NEMO3.6 (trunk) cla_init is called twice for the ORCA2 configuration. The first time in nemogcm.F90 line 439 (rev #5407):

IF( nn_cla == 1 .AND. cp_cfg == 'orca' .AND. jp_cfg == 2 ) CALL cla_init ! Cross Land Advection

and the second time because cal_div is called from divcur.F90 line 232 (rev#5516):

IF( nn_cla == 1 ) CALL cla_div ( kt ) ! Cross Land Advection (Update Hor. divergence)

which itself called cla_init at line 80 (rev #4147) as part of the nit000 initialization.

Unless we are mistaken, one of those calls is redundant. Since a memory allocation occurs in this routine, it crashes (at least for us) because the model is trying to allocate memory twice for the same arrays.

Commit History (1)

ChangesetAuthorTimeChangeLog
8538gm2017-09-19T08:02:33+02:00

#1558 : minor bug correction: remove double call of cla_init

Change History (2)

comment:1 Changed 6 years ago by gm

  • Type changed from Bug to Defect
  • Version changed from trunk to v3.6

comment:2 Changed 6 years ago by gm

  • Resolution set to fixed
  • Status changed from new to closed

Thanks Fred for reporting this bug.

Note that v3.6 is the last version with cross -land advection. This option has been removed from the trunk in December 2016.  

Note: See TracTickets for help on using tickets.