New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1617 (BUG in domzgr.F90 when defining the envelop bathymetry (both v3.6 stable & trunk)) – NEMO

Opened 7 years ago

Closed 6 years ago

#1617 closed Bug (fixed)

BUG in domzgr.F90 when defining the envelop bathymetry (both v3.6 stable & trunk)

Reported by: gm Owned by: timgraham
Priority: low Milestone:
Component: OCE Version: trunk
Severity: Keywords: SCO trunk
Cc:

Description (last modified by nicolasmartin)

In domzgr.F90, lines 1873 , bathy(iim1,ijm1) appears twice !

This seams to be a BUG. Someone can confirm this ?

Replace the following lines:

1872       IF( (bathy(iip1,jj) + bathy(iim1,jj) + bathy(ji,ijp1) + bathy(ji,ijm1) +              &
1873  &         bathy(iip1,ijp1) + bathy(iim1,ijm1) + bathy(iip1,ijp1) + bathy(iim1,ijm1)) > 0._wp ) THEN
1874         zenv(ji,jj) = rn_sbot_min
1875        ENDIF

by the much readable (and bug free) following lines

IF( ( + bathy(iim1,ipm1) + bathy(ji,ijp1) + bathy(iip1,ijp1)  &
   &  + bathy(iim1,jj  )                  + bathy(iip1,jj  )  &
   &  + bathy(iim1,ijm1) + bathy(ji,ijm1) + bathy(iip1,ijp1)  ) > 0._wp ) THEN
   zenv(ji,jj) = rn_sbot_min
ENDIF

Gurvan

Commit History (1)

ChangesetAuthorTimeChangeLog
6036timgraham2015-12-11T16:04:27+01:00

Fix for ticket #1617 - should have no impact on results

Change History (5)

comment:1 Changed 7 years ago by timgraham

  • Milestone 2015 nemo_v3_6_STABLE deleted
  • Owner changed from NEMO team to timgraham
  • Version changed from v3.6 to trunk

Yes this is a bug although it won't have any impact on results. I've committed the fix at r6036 in nemo_3.6_stable. Note there was a small error in the fix suggested (ipm1 doesn't exist). The correct fix is

IF( ( + bathy(iim1,ijp1) + bathy(ji,ijp1) + bathy(iip1,ijp1)  &
   &  + bathy(iim1,jj  )                  + bathy(iip1,jj  )  &
   &  + bathy(iim1,ijm1) + bathy(ji,ijm1) + bathy(iip1,ijp1)  ) > 0._wp ) THEN
   zenv(ji,jj) = rn_sbot_min
ENDIF

We should commit the fix to the trunk at or following the merge party.

comment:2 Changed 7 years ago by nicolasmartin

  • Description modified (diff)

Well, 2 parameters 'fse3t' & 'tb' have changed in the restarts of AMM12 configuration, no impact on solver.stat or ocean.output.

Does that seem consistent ?

comment:3 Changed 7 years ago by nicolasmartin

  • Keywords s-coordinates added; s-coordinate removed

comment:4 Changed 7 years ago by nicolasmartin

  • Keywords SCO trunk added; s-coordinates removed

comment:5 Changed 6 years ago by timgraham

  • Resolution set to fixed
  • Status changed from new to closed

This has been corrected in nemo_v3_6_stable and was fixed in the DOMAINcfg tool as part of last year's merge

Note: See TracTickets for help on using tickets.