Opened 9 years ago
Closed 8 years ago
#1618 closed Bug (fixed)
bug in code (incomplete code?) if ln_mask_file = .true. in bdyini.F90
Reported by: | jamesharle | Owned by: | jamesharle |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | OCE | Version: | trunk |
Severity: | Keywords: | BDY | |
Cc: |
Description
I've been trying a few regional simulations using bdy_msk to define my region. After looking at the restart files it appears that even the domain outside the bdy_msk is 'active'. Looking at bdyini.F90 bdytmask appears to be overwritten (at ln 1161 with ssmask) after the bdy_msk is read in. There are also several new mask arrays defined in dommsk.F90 that are not updated here - maybe they don't need to be - but I couldn't correct the issues I had running with a bdy_msk. I thought the cleanest way (rather than updating a bunch of mask arrays after they'd been calculated - and also liable to change in future versions) was just to perform a single update to the tmask in dommsk using bdy_msk and remove all the mask update code in bdyini.F90 (which solved my problems).. Good, bad or ugly? Attached are two patches at revision 5840.
Commit History (1)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
6946 | jamesharle | 2016-09-23T12:41:24+02:00 | Address ticket #1618: bdy_msk not masking |
Attachments (2)
Change History (5)
Changed 9 years ago by jamesharle
Changed 9 years ago by jamesharle
comment:1 Changed 9 years ago by jamesharle
- Owner changed from NEMO team to jamesharle
comment:2 Changed 9 years ago by nicolasmartin
- Keywords BDY added; bdy removed
comment:3 Changed 8 years ago by jamesharle
- Resolution set to fixed
- Status changed from new to closed
This code was added in the 2016 merge.