New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1665 (bug in domzgr.F90 if horizontal mesh is an f-plane (jphgr_msh = 2) and correction for tapered s-coordinates in vicinity of Equator) – NEMO

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#1665 closed Bug (fixed)

bug in domzgr.F90 if horizontal mesh is an f-plane (jphgr_msh = 2) and correction for tapered s-coordinates in vicinity of Equator

Reported by: flavoni Owned by: flavoni
Priority: low Milestone:
Component: OCE Version: trunk
Severity: Keywords: SCO
Cc:

Description (last modified by nicolasmartin)

Correction applied in domzgr.F90:

     ! Envelope bathymetry saved in hbatt
      hbatt(:,:) = zenv(:,:)
      IF( MINVAL(''' gphit(:,:) ) * MAXVAL( gphit(:,:) ) <= 0.'''_wp ) THEN
         CALL ctl_warn( ' s-coordinates are tapered in vicinity of the Equator' )
         DO jj = 1, jpj
            DO ji = 1, jpi
               ztaper = EXP( -(gphit(ji,jj)/8._wp)**2._wp )
               hbatt(ji,jj) = rn_sbot_max * ztaper + hbatt(ji,jj) * ( 1._wp - ztaper )
            END DO
         END DO
      ENDIF

is not correct in the case of an analytical grid.

In this case the value of gphit is zero; so the correction is applied but NOT needed.

This correction is in all versions of NEMO: trunk, 3_6_stable, etc...

Do we keep this correction?
In this case the if condition is not well defined.

Commit History (1)

ChangesetAuthorTimeChangeLog
8593flavoni2017-10-05T10:28:32+02:00

#1665, stop : don't apply modification at Equator when mesh is given in Km and s-coordinates

Change History (6)

comment:1 Changed 6 years ago by nicolasmartin

  • Keywords SCO added; s-coordinates removed

comment:2 Changed 6 years ago by nicolasmartin

  • Keywords nemo_v3_6* added

comment:3 Changed 5 years ago by nicolasmartin

  • Description modified (diff)
  • Owner nemo deleted
  • Status changed from new to assigned

comment:4 Changed 5 years ago by clevy

  • Milestone 2015 nemo_v3_6_STABLE deleted
  • Owner set to flavoni

comment:5 Changed 5 years ago by flavoni

  • Keywords nemo_v3_6* removed
  • Priority changed from major to minor

comment:6 Changed 5 years ago by flavoni

  • Resolution set to fixed
  • Status changed from assigned to closed

Add a stop in domzgr.F90 routine in changeset [8594] for 3_6_STABLE,
and add a stop in TOOLS/DOMAINcfg/src/domzgr.f90 routine in changeset [8593] for trunk.

Note: See TracTickets for help on using tickets.