New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1668 (Argument var_nodims when calling oasis3-mct_3.0 oasis_def_var routine) – NEMO

Opened 7 years ago

Closed 4 years ago

#1668 closed Enhancement (fixed)

Argument var_nodims when calling oasis3-mct_3.0 oasis_def_var routine

Reported by: valcke Owned by: smasson
Priority: low Milestone:
Component: OCE Version: v3.6
Severity: minor Keywords:
Cc: smasson

Description

When calling oasis_def_var, the 4th argument var_nodims is (2,0) whereas it should be (2,1). It has no impact for now but his si not clean (and maybe will have an impact with further oasis3-mct version when bundle fields will be supported.

Commit History (0)

(No commits)

Change History (3)

comment:1 Changed 5 years ago by clevy

  • Cc smasson added
  • Owner changed from nemo to smasson
  • Status changed from new to assigned

comment:2 Changed 4 years ago by frrh

  • Severity set to minor

Hi Sophie & Seb,

I'm just adding a comment here because I've been testing NEMO with OASIS3-MCT version 4.0.

There are appear to be two issues with the NEMO code in CPL_OASIS3.F90 which are at odds with vn4.0 of the coupler.

The first is the use of var_nodims which you mention in the description of this ticket.

In the code, it's written as a literal argument (/2,0/) but presumably now wants to be made more flexible by using
an array, say, nemo_var_dims(1) = 2 and nemo_var_dims(2) = nbundle to cater for bundle fields
even if nbundle just defaults to 1.

The second issue actually causes a compilation failure because ishape is dimensioned as (2,2) and
sets the values thus

         ishape(:,1) = (/ 1, nlei-nldi+1 /)
         ishape(:,2) = (/ 1, nlej-nldj+1 /) 

That was fine for OASIS3-MCT vn3.0 (or at least it worked OK because the psmile interface
was not fussy about the format of the array as long as it got the right number of elements
in the right order).
But at vn4.0 the psmile interface demands that ishape is a 1D array, so we have to
dimension ishape(1:4) and set:

  ishape(1) = 1
  ishape(2) = nlei-nldi+1
  ishape(3) = 1
  ishape(4) = nlej-nldj+1

I was originally going to open my own ticket, but then I found this one, so I guess these
things are best addressed by this ticket.

Regards,

Richard


Last edited 4 years ago by nemo (previous) (diff)

comment:3 Changed 4 years ago by smasson

  • Resolution set to fixed
  • Status changed from assigned to closed

done in the trunk, see [10404]

Note: See TracTickets for help on using tickets.