New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1759 (diatmb.F90 : small error in z- and zps coordinate, wrong in s-coordinate) – NEMO

Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#1759 closed Bug (fixed)

diatmb.F90 : small error in z- and zps coordinate, wrong in s-coordinate

Reported by: gm Owned by: acc
Priority: low Milestone:
Component: OCE Version: trunk
Severity: minor Keywords: diatmb
Cc: acc

Description

Context

It is only a diagnostic issue which concern both v3.6_stable and trunk.
The top, middle and bottom output of tracer and horizontal velocity done diatmb.F90 module has several issues that can be rather easily solved (see below).
It should also be generalized to all available vertical coordinate and take into account ice-shelf cavities.

Analysis & Fix

1- Better to use mkbt which is directly the level needed (with 1 on land) instead of mbathy array.

2- small  BUG for u- and v-points mid and bottom calculation: the use of mbathy is wrong !
===>>>> mbku and mbkv should be used instead

3- mid depth diag. case: here only the z-coordinate is OK.

For zps there will be a small error at the boundary.
For s-coordinate, the diag is just wrong. Either add "IF(  ln_sco )   CALL ctl_stop(....)" in dia_tmb_init or adapt the diag to s-coordinate.

4- surface diag. case : in case of ice shelf cavities, the top of the ocean is not the level  k=1, but the bottom go the ice shelves. use mikt, miku or mikv (for t-, u-, or v-point)  

Commit History (3)

ChangesetAuthorTimeChangeLog
12230smasson2019-12-12T18:15:21+01:00

trunk: missing part in supressing diatmb, see #1759

12207smasson2019-12-12T12:15:33+01:00

trunk: supress diatmb as it was bugged and already coded in diawri, see #1759

12206smasson2019-12-12T12:14:55+01:00

trunk: supress diatmb as it was bugged and already coded in diawri, see #1759

Change History (6)

comment:1 Changed 5 years ago by clevy

  • Cc acc added
  • Owner changed from nemo to acc
  • Status changed from new to assigned

comment:2 Changed 5 years ago by nicolasmartin

  • Version changed from v3.6 to trunk

comment:3 Changed 3 years ago by smasson

In 12206:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:4 Changed 3 years ago by smasson

In 12207:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:5 Changed 3 years ago by smasson

  • Resolution set to fixed
  • Severity set to minor
  • Status changed from assigned to closed

top and bottom variables are already coded in diawri.
if needed, coding "middle" variables following what is done for top and bottom would be trivial.

comment:6 Changed 3 years ago by smasson

In 12230:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found
Note: See TracTickets for help on using tickets.