Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#1823 closed Bug (fixed)

two bugs in tracer trends diagnostics at 3.6_STABLE

Reported by: davestorkey Owned by: davestorkey
Priority: low Milestone: 2015 release-3.6
Component: OCE Version: release-3.6
Severity: Keywords:
Cc: Branch review:
MP ready?: Task progress:

Description

Context


Analysis

There are two bugs in the tracer trends diagnostics that have been introduced accidentally as part of the update for CMIP6:

  1. The "pure" vertical trend ("trd_zdfp") is calculated in trd_tra. This diagnostic used to include the mixing due to the EVD convection scheme but the avt coefficient was mistakenly changed to avt_k (excluding the EVD convection). This needs to be changed back.
  2. A bug was introduced in the calculation of the trend due to the Asselin time-filtering in tra_nxt. The zdrdt and zdrds arrays are incorrectly initialised for this calculation.

Fix


Commit History (2)

ChangesetAuthorTimeChangeLog
7556davestorkey2017-01-13T14:46:22+01:00

Updates for tracer trends diagnostics in dev_merge_2016:

  1. Add in calls for total trend diagnostics in tra_nxt.
  2. Fix bug in calculation of trd_zdfp as detailed in ticket #1823.
7555davestorkey2017-01-13T14:31:43+01:00

Fix two bugs in tracer trends diagnostics. Ticket #1823.

Change History (3)

comment:1 Changed 4 years ago by davestorkey

  • Resolution set to fixed
  • Status changed from new to closed

Bug fixed in nemo_v_3_6_STABLE at revision 7555. I have also updated the dev_merge_2016 branch.

Note that the original NEMO choice of including the EVD mixing in the trd_zdfp diagnostic is consistent with the CMIP6 requirement.

comment:2 Changed 3 years ago by nemo

  • Keywords release-3.6* added

comment:3 Changed 3 years ago by nemo

  • Keywords release-3.6* removed
Note: See TracTickets for help on using tickets.