Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#1837 closed Bug (fixed)

Fix LIM2-VP for AGRIF

Reported by: fschwarzkopf Owned by: nemo
Priority: normal Milestone:
Component: AGRIF Version: release-3.6
Severity: Keywords: AGRIF LIM* VP
Cc: Branch review:
MP ready?: Task progress:

Description

Context

LIM2-VP does not work with AGRIF

Analysis

In agrif_lim2_interp.F90 the variable names for the zonal and meridional ice velocities in the LIM2-VP case are inconsistent between different subroutines.

In agrif_rhg_lim2_load the variable names are defined to be u_ice_nst and v_ice_nst, whereas in interp_u_ice and interp_v_ice the names from the EVP case uice_agr and vice_agr are used, but not defined:

Exemplarily for interp_u_ice:

519 #if defined key_lim2_vp
520       IF( before ) THEN
521          DO jj=MAX(j1,2),j2
522             DO ji=MAX(i1,2),i2
523                IF( tmu(ji,jj) == 0. ) THEN
524                   tabres(ji,jj) = -9999.
525                ELSE
526                   tabres(ji,jj) = e2f(ji-1,jj-1) * u_ice(ji,jj)
527                ENDIF
528             END DO
529          END DO
530       ELSE
531          DO jj=MAX(j1,2),j2
532             DO ji=MAX(i1,2),i2
533                uice_agr(ji,jj) = tabres(ji,jj)
534             END DO
535          END DO
536       ENDIF
537 #else
538       IF( before ) THEN
539          DO jj= j1, j2
540             DO ji= i1, i2
541                IF( umask(ji,jj,1) == 0. ) THEN
542                   tabres(ji,jj) = -9999.
543                ELSE
544                   tabres(ji,jj) = e2u(ji,jj) * u_ice(ji,jj)
545                ENDIF
546             END DO
547          END DO
548       ELSE
549          DO jj= j1, j2
550             DO ji= i1, i2
551                uice_agr(ji,jj) = tabres(ji,jj)
552             END DO
553          END DO
554       ENDIF
555 #endif

Fix

Change to the correct names in subroutines interp_u_ice:

533                u_ice_nst(ji,jj) = tabres(ji,jj)

and interp_v_ice:

584                v_ice_nst(ji,jj) = tabres(ji,jj)

Commit History (1)

ChangesetAuthorTimeChangeLog
7639clem2017-02-03T15:58:14+01:00

bug fix for AGRIF+LIM2-VP, see ticket #1837

Change History (4)

comment:1 Changed 4 years ago by clem

  • Resolution set to fixed
  • Status changed from new to closed

fixed at revision 7639

comment:2 Changed 3 years ago by nemo

  • Keywords LIM* added; LIM2 removed

comment:3 Changed 3 years ago by nemo

  • Keywords release-3.6* added

comment:4 Changed 3 years ago by nemo

  • Keywords release-3.6* removed
Note: See TracTickets for help on using tickets.