bug when reading external data in BDY?

[clem]

I am wondering if there is a problem in BDY when reading external files with option ln_full_vel_array = .FALSE.

In bdydta.F90 (~line 266), data from external files are read as follows:

IF( PRESENT(jit) ) THEN

  IF( ln_full_vel_array(ib_bdy) ) THEN
    CALL fld_read( kt=kt, kn_fsbc=1, sd=bf(jstart:jend), map=nbmap_ptr(jstart:jend),  &
       & kit=jit, kt_offset=time_offset , jpk_bdy=nb_jpk_bdy, fvl=ln_full_vel_array(ib_bdy)  )
  ELSE
    CALL fld_read( kt=kt, kn_fsbc=1, sd=bf(jstart:jend), map=nbmap_ptr(jstart:jend),  &
       & kit=jit, kt_offset=time_offset  )
  ENDIF

ELSE

  CALL fld_read( kt=kt, kn_fsbc=1, sd=bf(jstart:jend), &
    & map=nbmap_ptr(jstart:jend), kt_offset=time_offset, jpk_bdy=nb_jpk_bdy, fvl=ln_full_vel_array(ib_bdy) )

ENDIF

It looks to me that below the ELSE statement, there is a missing IF( ln_full_vel_array(ib_bdy) )
Can someone confirm or refute?

[jchanut]

First note that the case "( PRESENT(jit)) =T" never occurs in the code anymore. This is a remaining part of the former update of boundary conditions at each barotropic time step. Some cleaning would be needed here.

The problem I see is that with "runoff" boundary conditions ONLY (this a tracer boundary condition, which is not really, well, understandable) the code never considers the the ln_full_vel_array flag so that 2d transport as input is always expected. 

Replying to clem:

I am wondering if there is a problem in BDY when reading external files with option ln_full_vel_array = .FALSE.

In bdydta.F90 (~line 266), data from external files are read as follows:

IF( PRESENT(jit) ) THEN

IF( ln_full_vel_array(ib_bdy) ) THEN
CALL fld_read( kt=kt, kn_fsbc=1, sd=bf(jstart:jend), map=nbmap_ptr(jstart:jend),  &
& kit=jit, kt_offset=time_offset , jpk_bdy=nb_jpk_bdy, fvl=ln_full_vel_array(ib_bdy)  )
ELSE
CALL fld_read( kt=kt, kn_fsbc=1, sd=bf(jstart:jend), map=nbmap_ptr(jstart:jend),  &
& kit=jit, kt_offset=time_offset  )
ENDIF

ELSE

CALL fld_read( kt=kt, kn_fsbc=1, sd=bf(jstart:jend), &
& map=nbmap_ptr(jstart:jend), kt_offset=time_offset, jpk_bdy=nb_jpk_bdy, fvl=ln_full_vel_array(ib_bdy) )

ENDIF

It looks to me that below the ELSE statement, there is a missing IF( ln_full_vel_array(ib_bdy) )
Can someone confirm or refute?

[clevy]

Should be checked and eventually changes in dev_merge_2017 for now, as the future trunk