O2L3P cfg. compilation crash with GCC in trcbc.f90

[nicolasmartin]

Context

I gave a try to run ORCA2_LIM3_PISCES configuration for some tests on my personal laptop but failed to compile it successfully.

/home/ntm/Workspace/NEMO/trunk/NEMOGCM/CONFIG/O2L3P/BLD/ppsrc/nemo/trcbc.f90:90.38:

      NAMELIST/namtrc_bdy/ cn_trc_dflt, cn_trc, nn_trcdmp_bdy
                                      1
Error: NAMELIST attribute conflicts with ALLOCATABLE attribute in 'cn_trc_dflt' at (1)
/home/ntm/Workspace/NEMO/trunk/NEMOGCM/CONFIG/O2L3P/BLD/ppsrc/nemo/trcbc.f90:137.38:

         READ ( numnat_ref, namtrc_bdy, IOSTAT = ios, ERR = 903)
                                      1
Error: Symbol 'namtrc_bdy' at (1) has no IMPLICIT type

Analysis

My GCC compiler is a bit old (v4.4.7 20120313) and the Trusting monitoring couldn't detect it because it uses only ifort.

Fix

With Christian, we found a workaround by removing the dynamical allocation on trc.f90 (compliant with BDY routines)

../NEMO/TOP_SRC/trc.F90

@@ -9 +9 @@
    !!----------------------------------------------------------------------
    USE par_oce
    USE par_trc
-   USE bdy_oce, only: ln_bdy, nb_bdy, OBC_DATA
+   USE bdy_oce, only: jp_bdy, ln_bdy, nb_bdy, OBC_DATA
    
    IMPLICIT NONE
    PUBLIC
@@ -168 +168 @@
    REAL(wp), PUBLIC, ALLOCATABLE, SAVE, DIMENSION(:,:,:)   ::  avs_temp      !: salinity vertical diffusivity coeff. at w-point   [m/s]
 # endif
    !
-   CHARACTER(len=20), PUBLIC, ALLOCATABLE,  SAVE,  DIMENSION(:)   ::  cn_trc_dflt          ! Default OBC condition for all tracers
-   CHARACTER(len=20), PUBLIC, ALLOCATABLE,  SAVE,  DIMENSION(:)   ::  cn_trc               ! Choice of boundary condition for tracers
-   INTEGER,           PUBLIC, ALLOCATABLE,  SAVE,  DIMENSION(:)   ::  nn_trcdmp_bdy        !: =T Tracer damping
+   CHARACTER(len=20), PUBLIC, DIMENSION(jp_bdy) :: cn_trc_dflt   ! Default OBC condition for all tracers
+   CHARACTER(len=20), PUBLIC, DIMENSION(jp_bdy) :: cn_trc        ! Choice of boundary condition for tracers
+   INTEGER,           PUBLIC, DIMENSION(jp_bdy) :: nn_trcdmp_bdy !: =T Tracer damping
 !$AGRIF_DO_NOT_TREAT
    ! External data structure of BDY for TOP. Available elements: cn_obc, ll_trc, trcnow, dmp
    TYPE(OBC_DATA),    PUBLIC, ALLOCATABLE, DIMENSION(:,:), TARGET ::  trcdta_bdy           !: bdy external data (local process)
@@ -205 +205 @@
          &      STAT = ierr(1)  )
       !
       IF ( ln_bdy ) THEN
-         ALLOCATE( cn_trc_dflt(nb_bdy)   , cn_trc(nb_bdy)     , nn_trcdmp_bdy(nb_bdy) ,       &
-         &      trcdta_bdy(jptra,nb_bdy)                                              ,       &
-         &      STAT = ierr(2)  )
+         ALLOCATE( trcdta_bdy(jptra, jp_bdy), STAT = ierr(2) )
       ENDIF
       !
       IF (jp_dia3d > 0 ) ALLOCATE( trc3d(jpi,jpj,jpk,jp_dia3d), STAT = ierr(3) )

[flavoni]

fix by rachid, see @8328.

[nicolasmartin]

The r8328 does not concern this ticket, there is a typo in the ticket number.
Unfortunately Rachid is not able to fix a bug before we identified it :-P

[nicolasmartin]

Unable to reproduce the issue while trying just now with the same environment.

So the issue was somewhere else in the code and probably fixed by latest commits as trcbc.f90 has not evolved since last MP.

[nicolasmartin]

Probably need a bit rest by the end of this week.

The issue were on trc.F90 and still there.

[nicolasmartin]

In 8665:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[nicolasmartin]

The commit message has closed the ticket as expected with [close #1929] but no notification has been send.

Seems to be difficult to divert from Trac core thanks to plugins and get everything working as planned.