Opened 6 years ago
Closed 4 years ago
#2119 closed Defect (wontfix)
improved land-processor suppression
Reported by: | smasson | Owned by: | systeam |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | OCE | Version: | trunk |
Severity: | minor | Keywords: | |
Cc: |
Description (last modified by nicolasmartin)
Context
Today, land-processor are suppressed only if they are completely in a land.
I think, since the recent modifications in mppini, we could suppress domains, which have only their internal area (from nldi/j to nlei/j) in land.
This append for example with ORCA2 with a 7x4 decomposition. Today we must put jpnij = 27, we should be able to put 26.
Proposal
replace in mppini.F90
! ! Check wet points over the entire domain to preserve the MPI communication stencil isurf = 0 DO jj = 1, ilj DO ji = 1, ili
by
! ! Check wet points over the internal domain as MPI communication stencil will be latter modified in case of domain suppression isurf = 0 DO jj = ildj(ii,ij), ilej(ii,ij) DO ji = ildi(ii,ij), ilei(ii,ij)
Commit History (0)
(No commits)
Change History (5)
comment:1 Changed 6 years ago by smasson
- Description modified (diff)
comment:2 Changed 6 years ago by smasson
comment:3 Changed 6 years ago by nicolasmartin
- Description modified (diff)
comment:4 Changed 4 years ago by clevy
- Type changed from Enhancement to Defect
comment:5 Changed 4 years ago by smasson
- Resolution set to wontfix
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
In fact we have to be careful with the corners...
As we do east-west communications first and next north-south communications, the corner values are obtained through the north-south exchanges.
We therefore have to take care of the northern and southern neighbors of the land-domain we want to suppress. The corner values of these neighbors won't be received anymore, so we have to make sure they are land points. These corners points are also existing on the overlapping bands of the land-domain we want to suppress, their position is
So to suppress a land-domain, we have to make sure its internal area and these 4 points (if this domain has norther and/or southern neighbors) are land-points.