New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2130 (Bug in calculation of initial day when not starting from 00Z) – NEMO

Opened 5 years ago

Closed 3 years ago

#2130 closed Bug (fixed)

Bug in calculation of initial day when not starting from 00Z

Reported by: charris Owned by: systeam
Priority: low Milestone:
Component: DOM Version: trunk
Severity: minor Keywords:
Cc: timgraham

Description (last modified by nicolasmartin)

Context

There is a bug in the implementation of the nn_time0 functionality such that the initial day can potentially be set incorrectly.

Analysis

source:/NEMO/trunk/src/OCE/DOM/daymod.F90?rev=10068#L95​ is written as if nn_time0 was 'HH' (as in a previous version of this code) rather than 'HHMM' as in the version committed to the trunk.

Fix

Replace this line with

      IF( nhour*3600 + nminute*60 - ndt05 .lt. 0 ) fjulday = fjulday + 1.                    ! move back to the day at nit000 (and not at nit000 - 1)

Commit History (1)

ChangesetAuthorTimeChangeLog
12158jchanut2019-12-10T16:33:19+01:00

#2130, correct initial day if not starting at 00Z

Change History (4)

comment:1 Changed 5 years ago by nicolasmartin

  • Description modified (diff)

comment:2 Changed 5 years ago by nicolasmartin

  • Version set to trunk

comment:3 Changed 3 years ago by jchanut

In 12158:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:4 Changed 3 years ago by smasson

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.