#2211 closed Defect (fixed)
The linking of BDY code fails in a non-MPP configuration
| Reported by: | smueller | Owned by: | smueller |
|---|---|---|---|
| Priority: | low | Milestone: | 2018 release-4.0 |
| Component: | BDY | Version: | trunk |
| Severity: | minor | Keywords: | non-MPP v4.0 |
| Cc: |
Description
Context
In a non-MPP configuration, the linking of BDY code fails due to undefined references to "ctl_stop_".
Analysis
The modules bdydyn2d, bdydyn3d, bdylib, and bdytra of the BDY component include calls to subroutine ctl_stop without explicit reference to lib_mpp (i.e., without 'use lib_mpp' statement). In the source code that is generated when key_mpp_mpi is defined, access to ctl_stop in these modules is provided indirectly via the lbclnk module; in non-MPP configurations, however, module lbclnk does not provide access to ctl_stop.
Recommendation
The non-MPP variant of the source code for module lbclnk could be extended to provide access to subroutine ctl_stop. This could be achieved with two modifications of the section of file src/OCE/LBC/lbclnk.F90 that is selected when key_mpp_mpi is undefined: i) a replication of the 'use lib_mpp' statement from the source code for the MPP variant of the lbclnk module, and ii) the declaration of ctl_stop as public after the setting of the default accessibility attribute to private.
Commit History (1)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 10529 | smasson | 2019-01-16T11:40:44+01:00 | trunk: bugfix in BDY routines for non-MPP compilation, see #2211 |
Change History (4)
comment:1 Changed 5 years ago by smueller
- Owner changed from systeam to smueller
- Status changed from new to assigned
comment:2 Changed 5 years ago by smasson
comment:3 Changed 5 years ago by smasson
- Resolution set to fixed
- Status changed from assigned to closed
comment:4 Changed 20 months ago by nemo
- Keywords v4.0 added
In 10529: