New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2219 (Suspected wrong declaration of ztrans in src/ICE/icevar.F90) – NEMO

Opened 5 years ago

Closed 5 years ago

Last modified 22 months ago

#2219 closed Defect (fixed)

Suspected wrong declaration of ztrans in src/ICE/icevar.F90

Reported by: kmogensen Owned by: systeam
Priority: low Milestone:
Component: SI3 Version: v4.0
Severity: major Keywords: v4.0
Cc:

Description

Context

In line 798 in src/ICE/icevar.F90 I read the following:

   INTEGER, PARAMETER ::   ztrans = 0.25_wp

Analysis

I suspect that this variable should have been declared as REAL(wp).

Recommendation

...

Commit History (1)

ChangesetAuthorTimeChangeLog
10589clem2019-01-28T13:01:54+01:00

fix bug #2219

Change History (5)

comment:1 Changed 5 years ago by clem

In 10589:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:2 Changed 5 years ago by clem

  • Resolution set to fixed
  • Status changed from new to closed

yes indeed. I do not know what the compiler is doing with such a thing. I hope the value remains 0.25.
It must be corrected asap, you are right. Done at r10589

comment:3 Changed 5 years ago by kmogensen

For info: Gfortran was complaining about the declaration which is why I noticed it. So I suspect that for that particular compiler it value would be 0 rather than 0.25.

comment:4 Changed 5 years ago by molines

Just a small comment :
A real parameter should have a name starting with pp_ for readibily So in this case it might be pp_trans for example !

In fact I think it is very pleasant to read the code when it follows the coding rules ...

Jean-Marc

comment:5 Changed 22 months ago by nemo

  • Keywords v4.0 added
Note: See TracTickets for help on using tickets.