out of bound in mpp_min/maxloc if land processor not removed

[mathiot]

BE CAREFUL !!! Due to dynamic behaviour of this ticket creation page, it is highly recommend to set first all other fields before writing the ticket description below.
If you have lost your draft after an unwanted reload, you can click on the link 'Restore Form' in the contextual menu upper right to recover it.
Remove these lines after reading.

Context

By looking of the job output in debug mode, I found some out of bound in mpp_minloc.

We can see it in the ocean.output of ORCA2_ICE_PISCES in a 8x4 decomposition (ie some land processors are present):

 dom_ctl : extrema of the masked scale factors
 ~~~~~~~
              e1t maxi:  222397.85 at i =     2 j=    74
              e1t mini:       0.00 at i =   182 j=   110
              e2t maxi:  209504.00 at i =     5 j=    92
              e2t mini:       0.00 at i =   182 j=   110

Instead of this in a 4x8 decomposition (no land processor):

 dom_ctl : extrema of the masked scale factors
 ~~~~~~~
              e1t maxi:  222397.85 at i =     2 j=    74
              e1t mini:   47096.05 at i =    51 j=     2
              e2t maxi:  209504.00 at i =     5 j=    92
              e2t mini:   47096.05 at i =    51 j=     2

Analysis

In case the whole local mask is 0, the MINLOC statement retrun (0,0) as indexes => out of bound later on.

It affect the trunk and version 4.0.

Fix

Set the min/max value for this domain to HUGE/TINY and the variable index0 to 0

[mathiot]

In 10651:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 10665:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

Branch branches/2019/fix_ticket2228 merged into trunk at revision r10665.

[mathiot]

In 10668:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

Commit r10665 leads to aew warning in the trunk (thank you Guillaume).

Fix: add #undef ERRVAL

[mathiot]

In 10716:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 10726:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found