Failure of AMM12 SETTE test

[jamesharle]

Context

On the ARCHER HPC facility the SETTE test for AMM12 fails with an XIOS "Numeric conversion not representable" from the 25 hour meaning diagnostics

Analysis

It appears that the 25 hour mean vertical velocity array (wn_25h) is initialised from wn (dia_25h_init), before wn has itself been initialised.

Fix

Delay the initialisation of wn_25h until the first call of dia_25h

dia25h.F90

@@ -99 +99 @@
       sshn_25h(:,:)   = sshb(:,:)
       un_25h  (:,:,:) = ub  (:,:,:)
       vn_25h  (:,:,:) = vb  (:,:,:)
-      wn_25h  (:,:,:) = wn  (:,:,:)
       avt_25h (:,:,:) = avt (:,:,:)
       avm_25h (:,:,:) = avm (:,:,:)
       IF( ln_zdftke ) THEN
@@ -148 +147 @@
       ! local variable for debugging
       ll_print = ll_print .AND. lwp
 
+      ! wn_25h could not be initialised in dia_25h_init, so we do it here instead
+      IF( kt == nn_it000 ) THEN
+         wn_25h(:,:,:) = wn(:,:,:)
+      ENDIF
+
       ! Sum of 25 hourly instantaneous values to give a 25h mean from 24hours every day
       IF( MOD( kt, i_steps ) == 0  .AND. kt /= nn_it000 ) THEN
 
@@ -222 +226 @@
          zw3d(:,:,:) = vn_25h(:,:,:)*vmask(:,:,:) + zmdi*(1.0-vmask(:,:,:))
          CALL iom_put("vomecrty25h", zw3d  )   ! j-current
          zw3d(:,:,:) = wn_25h(:,:,:)*wmask(:,:,:) + zmdi*(1.0-tmask(:,:,:))
-         CALL iom_put("vomecrtz25h", zw3d )   ! k-current
+         CALL iom_put("vovecrtz25h", zw3d )   ! k-current
          ! Write vertical physics
          zw3d(:,:,:) = avt_25h(:,:,:)*wmask(:,:,:) + zmdi*(1.0-tmask(:,:,:))
          CALL iom_put("avt25h", zw3d )   ! diffusivity

...

[jamesharle]

In 10640:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[jamesharle]

In 10644:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found