#2266 closed Defect (fixed)
The compilation of the source code for harmonic analysis fails
Reported by: | smueller | Owned by: | smueller |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | DIA | Version: | v4.0 |
Severity: | minor | Keywords: | compilation harmonic_analysis v4.0 |
Cc: |
Description (last modified by smueller)
Context
The compilation of the source code for the harmonic analysis of tidal constituents, which is activated when preprocessor key key_diaharm is defined, fails.
Analysis
There appears to be a misplaced error-message string in subroutine dia_harm_init of module diaharm, which has been introduced as part of changeset [10425]. The string includes the content of two undefined variables, which cause the compilation to fail when preprocessor key key_diaharm is defined.
Recommendation
The error-message string could be reverted to the version that was present immediately before changeset [10425] has been applied (NEMO/trunk/src/OCE/DIA/diaharm.F90@10068#L128).
Commit History (2)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
10833 | smueller | 2019-04-03T16:04:48+02:00 | Further modification of an error message string in module diaharm, see changeset [10832] and ticket #2266 |
10832 | smueller | 2019-04-03T15:55:41+02:00 | Reversion of an error-message string to the version at NEMO/trunk/src/OCE/DIA/diaharm.F90@10068#L128; fix for the defect described in ticket #2266 |
Change History (6)
comment:1 Changed 3 years ago by smasson
comment:2 Changed 3 years ago by smueller
- Description modified (diff)
- Owner changed from systeam to smueller
- Status changed from new to assigned
comment:3 Changed 3 years ago by smueller
In 10832:
comment:4 Changed 3 years ago by smueller
In 10833:
comment:5 Changed 3 years ago by smueller
- Resolution set to fixed
- Status changed from assigned to closed
The proposed modification of the error message has been applied (changesets [10832] and [10833]). The compilation of the source code at NEMO/releases/release-4.0@10833 with defined key_diaharm in reference configuration AMM12 (./makenemo -r AMM12 -n AMM12_test_r10833 add_key "key_diaharm") completes successfully.
comment:6 Changed 6 months ago by nemo
- Keywords v4.0 added
I guess, I made a copy and paste error...
This error message with XIOS has nothing to do in this routine!!
However, we must keep the other changes: use a proper call to ctl_stop to stop the model.
I propose to replace the definition of ctmp1 with the appropriate message: