The compilation of the source code for harmonic analysis fails

[smueller]

Context

The compilation of the source code for the harmonic analysis of tidal constituents, which is activated when preprocessor key key_diaharm is defined, fails.

Analysis

There appears to be a misplaced error-message string in subroutine dia_harm_init of module diaharm, which has been introduced as part of changeset [10425]. The string includes the content of two undefined variables, which cause the compilation to fail when preprocessor key key_diaharm is defined.

Recommendation

The error-message string could be reverted to the version that was present immediately before changeset [10425] has been applied (NEMO/trunk/src/OCE/DIA/diaharm.F90@10068#L128​).

[smasson]

I guess, I made a copy and paste error…
This error message with XIOS has nothing to do in this routine!!
However, we must keep the other changes: use a proper call to ctl_stop to stop the model.
I propose to replace the definition of ctmp1 with the appropriate message:

IF (nb_ana > jpmax_harmo) THEN
   WRITE(ctmp1,*) ' nb_ana must be lower than jpmax_harmo'
   WRITE(ctmp2,*) ' jpmax_harmo= ', jpmax_harmo
   CALL ctl_stop( 'dia_harm_init', ctmp1, ctmp2 )
ENDIF

[smueller]

In 10832:

Reversion of an error-message string to the version at NEMO/trunk/src/OCE/DIA/diaharm.F90@10068#L128​; fix for the defect described in ticket #2266

[smueller]

In 10833:

Further modification of an error message string in module diaharm, see changeset [10832] and ticket #2266

[smueller]

The proposed modification of the error message has been applied (changesets [10832] and [10833]). The compilation of the source code at NEMO/releases/release-4.0@10833​ with defined key_diaharm in reference configuration AMM12 (./makenemo -r AMM12 -n AMM12_test_r10833 add_key "key_diaharm") completes successfully.