New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2284 (Bug in NST/agrif_top_update.F90) – NEMO

Opened 3 years ago

Closed 3 years ago

Last modified 6 months ago

#2284 closed Bug (fixed)

Bug in NST/agrif_top_update.F90

Reported by: acc Owned by: jchanut
Priority: low Milestone: Unscheduled
Component: AGRIF Version: v4.0
Severity: minor Keywords: v4.0
Cc:

Description

Context

Whilst doing some branch work where, amongst other changes, we are changing the trb, trn and tra arrays, I noticed this at line 140 in NST/agrif_top_update.F90:

                          trb(ji,jj,jk,jn) = tsb(ji,jj,jk,jn) &
                                 & + atfp * ( tabres_child(ji,jj,jk,jn) &
                                 &          - trn(ji,jj,jk,jn) ) * tmask(ji,jj,jk)

Presumeably that tsb on the RHS should be a trb?

Analysis

The code doesn't seem to be active in any SETTE tests but does exist in the trunk and release-4.0.
...

Fix

Change tsb to trb if confirmed by an AGRIF expert.

Commit History (2)

ChangesetAuthorTimeChangeLog
11079jchanut2019-06-05T16:18:10+02:00

#2284

11078jchanut2019-06-05T16:17:09+02:00

#2284

Change History (6)

comment:1 Changed 3 years ago by jchanut

I confirm that's an ugly bug.

comment:2 Changed 3 years ago by clevy

  • Owner changed from systeam to jchanut
  • Status changed from new to assigned

comment:3 Changed 3 years ago by jchanut

In 11078:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:4 Changed 3 years ago by jchanut

In 11079:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:5 Changed 3 years ago by jchanut

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:6 Changed 6 months ago by nemo

  • Keywords v4.0 added
Note: See TracTickets for help on using tickets.