New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2299 (Minor bug in PISCES) – NEMO

Opened 3 years ago

Closed 3 years ago

Last modified 3 months ago

#2299 closed Defect (fixed)

Minor bug in PISCES

Reported by: cetlod Owned by: systeam
Priority: low Milestone:
Component: TOP Version: v4.0
Severity: minor Keywords: v4.0
Cc:

Description

BE CAREFUL !!! Due to dynamic behaviour of this ticket creation page, it is highly recommend to set first all other fields before writing the ticket description below.
If you have lost your draft after an unwanted reload, you can click on the link 'Restore Form' in the contextual menu upper right to recover it.
Remove these lines after reading.

Context

There is a duplicating effect of the ice in the production terms

Analysis

In p4zprod.F90, it seems like duplicating the effect of the ice.

   DO jk = 1, jpkm1
         DO jj = 1, jpj
            DO ji = 1, jpi
               zprbio(ji,jj,jk) = zprbio(ji,jj,jk) * ( 1. - fr_i(ji,jj) )
               zprdia(ji,jj,jk) = zprdia(ji,jj,jk) * ( 1. - fr_i(ji,jj) )
               zprbio(ji,jj,jk) = zprbio(ji,jj,jk) * ( 1. - fr_i(ji,jj) )
               zprdia(ji,jj,jk) = zprdia(ji,jj,jk) * ( 1. - fr_i(ji,jj) )
            END DO
         END DO
      END DO

Alessandro Tagliabue observed a big difference in the Arctic, lowering C uptake a lot - affecting Fe/C ratios

Recommendation

Remove the duplicating lines

Commit History (0)

(No commits)

Change History (4)

comment:1 Changed 3 years ago by cetlod

In 11117:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:2 Changed 3 years ago by cetlod

In 11118:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:3 Changed 3 years ago by cetlod

  • Resolution set to fixed
  • Status changed from new to closed

Done on v4.0 and trunk

comment:4 Changed 3 months ago by nemo

  • Keywords v4.0 added
Note: See TracTickets for help on using tickets.