jcat initialisation issue in icethd_do.F90

[mathiot]

Context

Sette test AGRIF_DEMO_ST REPRO_4_8 failed to run on METO computer.

Analysis

Initialisation of jcat is possibly not complete. If zh_newice(ji) < hi_max(0) (for example) jcat is not initialised in icethd_do:

         DO jl = 1, jpl
            DO ji = 1, npti
               IF( zh_newice(ji) > hi_max(jl-1) .AND. zh_newice(ji) <= hi_max(jl) ) THEN
                  a_i_2d(ji,jl) = a_i_2d(ji,jl) + za_newice(ji)
                  v_i_2d(ji,jl) = v_i_2d(ji,jl) + zv_newice(ji)
                  jcat(ji) = jl
               ENDIF
            END DO
         END DO

Then the model failed when jcat is used as an array index:

         ! Heat content
         DO ji = 1, npti
            jl = jcat(ji)                                                    ! categroy in which new ice is put
            zswinew  (ji) = MAX( 0._wp , SIGN( 1._wp , - za_b(ji,jl) ) )   ! 0 if old ice
         END DO

Fix

Suggested fix: make sure jcat is initialised everywhere (what default value to use for jcat in case of zh_newice negative or equal 0 (what I have for some points), I have no idea)

AGRIF_DEMO configuration with jcat = 1 by default runs and starts to diverge after 10 time steps

[clem]

the attached file should solve this issue by bounding the new sea ice thickness (though I do not know why it is mandatory for agrif only).
Pierre, could you try it and tell me if it works?

[clem]

In 11228:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[clem]

In 11229:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[clem]

zh_newice(ji) is always >= 0 and hi_max(0)=0, so zh_newice(ji) cannot be lower than hi_max(0)

[mathiot]

AGRIF_DEMO is running on our computer. Problem seems to be fix. Thank you Clem.