Wrong initialization of T/S open boundary data if set from initial state

[jchanut]

Context

In nambdy, if nn_tra_dta = 0 then open boundary data arrays are filled with initial fields. Currently, one gets zeros as boundary data values in that case.

Analysis

This done in bdydta thanks to the following lines (around line 165):

            IF( nn_tra_dta(jbdy) == 0 ) THEN
               ilen1(:) = nblen(:)
               IF( dta_bdy(jbdy)%lneed_tra ) THEN
                  igrd = 1
                  DO ib = 1, ilen1(igrd)
                     DO ik = 1, jpkm1
                        ii = idx_bdy(jbdy)%nbi(ib,igrd)
                        ij = idx_bdy(jbdy)%nbj(ib,igrd)
                        dta_bdy(jbdy)%tem(ib,ik) = tsn(ii,ij,ik,jp_bdytem) * tmask(ii,ij,ik)
                        dta_bdy(jbdy)%sal(ib,ik) = tsn(ii,ij,ik,jp_bdysal) * tmask(ii,ij,ik)
                        END DO
                  END DO
               ENDIF
            ENDIF

Fix

One should however take as the 4th dimension of tracers jp_tem and jp_sal repectively for T and S:

            IF( nn_tra_dta(jbdy) == 0 ) THEN
               ilen1(:) = nblen(:)
               IF( dta_bdy(jbdy)%lneed_tra ) THEN
                  igrd = 1
                  DO ib = 1, ilen1(igrd)
                     DO ik = 1, jpkm1
                        ii = idx_bdy(jbdy)%nbi(ib,igrd)
                        ij = idx_bdy(jbdy)%nbj(ib,igrd)
                        dta_bdy(jbdy)%tem(ib,ik) = tsn(ii,ij,ik,jp_tem) * tmask(ii,ij,ik)
                        dta_bdy(jbdy)%sal(ib,ik) = tsn(ii,ij,ik,jp_sal) * tmask(ii,ij,ik)
                        END DO
                  END DO
               ENDIF
            ENDIF

[jchanut]

In 12049:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[jchanut]

In 12050:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found