#2358 closed Bug (fixed)
bug in dynzdf when ln_drgimp and ln_isfcav
Reported by: | mathiot | Owned by: | mathiot |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | DYN | Version: | trunk |
Severity: | minor | Keywords: | |
Cc: |
Description
Context
Wrong indexes used for va and zwd in dynzdf with ln_drgimp and ln_isfcav set to .true. .
Analysis
It looks like a copy paste issue. This bug only affect the trunk with ln_drgimp and ln_isfcav set to .true. .
Fix
-
dynzdf.F90
148 148 ze3ua = ( 1._wp - r_vvl ) * e3u_n(ji,jj,iku) + r_vvl * e3u_a(ji,jj,iku) 149 149 ze3va = ( 1._wp - r_vvl ) * e3v_n(ji,jj,ikv) + r_vvl * e3v_a(ji,jj,ikv) 150 150 ua(ji,jj,iku) = ua(ji,jj,iku) + r2dt * 0.5*( rCdU_top(ji+1,jj)+rCdU_top(ji,jj) ) * ua_b(ji,jj) / ze3ua 151 va(ji,jj,ikv) = va(ji,jj,ikv) + r2dt * 0.5*( rCdU_top(ji +1,jj)+rCdU_top(ji,jj) ) * va_b(ji,jj) / ze3va151 va(ji,jj,ikv) = va(ji,jj,ikv) + r2dt * 0.5*( rCdU_top(ji,jj+1)+rCdU_top(ji,jj) ) * va_b(ji,jj) / ze3va 152 152 END DO 153 153 END DO 154 154 END IF … … 427 427 DO ji = 2, jpim1 428 428 ikv = mikv(ji,jj) ! (first wet ocean u- and v-points) 429 429 ze3va = ( 1._wp - r_vvl ) * e3v_n(ji,jj,ikv) + r_vvl * e3v_a(ji,jj,ikv) ! after scale factor at T-point 430 zwd(ji,jj,ik u) = zwd(ji,jj,iku) - r2dt * 0.5*( rCdU_top(ji+1,jj)+rCdU_top(ji,jj) ) / ze3va430 zwd(ji,jj,ikv) = zwd(ji,jj,ikv) - r2dt * 0.5*( rCdU_top(ji,jj+1)+rCdU_top(ji,jj) ) / ze3va 431 431 END DO 432 432 END DO 433 433 ENDIF
Commit History (2)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
12293 | mathiot | 2019-12-30T18:13:05+01:00 | part of ticket #2358 also affect dev_r11943_MERGE_2019 (option2 seems OK) |
12292 | mathiot | 2019-12-30T18:07:45+01:00 | fix #2358 |
Change History (2)
comment:1 Changed 5 years ago by mathiot
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 5 years ago by mathiot
In 12293:
Note: See
TracTickets for help on using
tickets.
In 12292: