Bug: U/V point interpolation of isf tbl tracer properties

[mathiot]

Context

Interpolation of the mean tracer properties in the isf top boundary layer on U/V point is wrong.

Analysis

It only affect the trunk and version 4. Version 3.6 is not affected. A fix has been included 2019 isf development and therefore included in the 2 dev_merge_2019 branches.

Recommendation

src/OCE/SBC/sbcisf.F90

@@ -741 +741 @@
       INTEGER ::   ikt, ikb                    ! top and bottom index of the tbl
       REAL(wp) ::   ze3, zhk
       REAL(wp), DIMENSION(jpi,jpj) :: zhisf_tbl ! thickness of the tbl
+      REAL(wp), DIMENSION(jpi,jpj) :: zvarout
       !!----------------------------------------------------------------------
       
       ! initialisation
@@ -748 +749 @@
    
       SELECT CASE ( cd_ptin )
       CASE ( 'U' ) ! compute U in the top boundary layer at T- point 
+         !
+         zvarout(:,:)=0._wp
+         !
          DO jj = 1,jpj
             DO ji = 1,jpi
                ikt = miku(ji,jj) ; ikb = miku(ji,jj)
@@ -763 +767 @@
                ! level fully include in the ice shelf boundary layer
                DO jk = ikt, ikb - 1
                   ze3 = e3u_n(ji,jj,jk)
-                  pvarout(ji,jj) = pvarout(ji,jj) + pvarin(ji,jj,jk) / zhisf_tbl(ji,jj) * ze3
+                  zvarout(ji,jj) = zvarout(ji,jj) + pvarin(ji,jj,jk) / zhisf_tbl(ji,jj) * ze3
                END DO
 
                ! level partially include in ice shelf boundary layer 
                zhk = SUM( e3u_n(ji, jj, ikt:ikb - 1)) / zhisf_tbl(ji,jj)
-               pvarout(ji,jj) = pvarout(ji,jj) + pvarin(ji,jj,ikb) * (1._wp - zhk)
+               zvarout(ji,jj) = zvarout(ji,jj) + pvarin(ji,jj,ikb) * (1._wp - zhk)
             END DO
          END DO
          DO jj = 2, jpj
             DO ji = 2, jpi
 !!gm a wet-point only average should be used here !!!
-               pvarout(ji,jj) = 0.5_wp * (pvarout(ji,jj) + pvarout(ji-1,jj))
+               pvarout(ji,jj) = 0.5_wp * (zvarout(ji,jj) + zvarout(ji-1,jj))
             END DO
          END DO
          CALL lbc_lnk('sbcisf', pvarout,'T',-1.)
       
       CASE ( 'V' ) ! compute V in the top boundary layer at T- point 
+         !
+         zvarout(:,:)=0._wp
+         !
          DO jj = 1,jpj
             DO ji = 1,jpi
                ikt = mikv(ji,jj) ; ikb = mikv(ji,jj)
@@ -795 +802 @@
                ! level fully include in the ice shelf boundary layer
                DO jk = ikt, ikb - 1
                   ze3 = e3v_n(ji,jj,jk)
-                  pvarout(ji,jj) = pvarout(ji,jj) + pvarin(ji,jj,jk) / zhisf_tbl(ji,jj) * ze3
+                  zvarout(ji,jj) = zvarout(ji,jj) + pvarin(ji,jj,jk) / zhisf_tbl(ji,jj) * ze3
                END DO
 
                ! level partially include in ice shelf boundary layer 
                zhk = SUM( e3v_n(ji, jj, ikt:ikb - 1)) / zhisf_tbl(ji,jj)
-               pvarout(ji,jj) = pvarout(ji,jj) + pvarin(ji,jj,ikb) * (1._wp - zhk)
+               zvarout(ji,jj) = zvarout(ji,jj) + pvarin(ji,jj,ikb) * (1._wp - zhk)
             END DO
          END DO
          DO jj = 2, jpj
             DO ji = 2, jpi
 !!gm a wet-point only average should be used here !!!
-               pvarout(ji,jj) = 0.5_wp * (pvarout(ji,jj) + pvarout(ji,jj-1))
+               pvarout(ji,jj) = 0.5_wp * (zvarout(ji,jj) + zvarout(ji,jj-1))
             END DO
          END DO
          CALL lbc_lnk('sbcisf', pvarout,'T',-1.)

[mathiot]

In 12294:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found