Opened 2 years ago

Closed 14 months ago

#2374 closed Defect (wontfix)

changes in option 2 version of iom.F90 which are not in the option 1 version

Reported by: acc Owned by: systeam
Priority: low Milestone:
Component: TOP Version:
Severity: minor Keywords:
Cc:

Description

Context

Whilst fixing iom.F90 for another ticket I noticed unexpected changes in the dev_r12072_MERGE_OPTION2_2019 version of iom.F90 that are not in the dev_r11943_MERGE_2019 version. For example:

734c733,734
<          iln    = INDEX(clname,'/')
---
> !FUS         iln    = INDEX(clname,'/')
>          iln    = INDEX(clname,'/',BACK=.true.)  ! FUS: to insert the nest index at the right location within the string, the last / has to be found (search from the right to left)

2303a2306,2307
>       CHARACTER(LEN=256) ::   cltmpn                 !FUS needed for correct path with AGRIF
>       INTEGER            ::   iln                    !FUS needed for correct path with AGRIF
2386c2390,2398
<             IF( jn == 1 .AND. TRIM(Agrif_CFixed()) /= '0' )   clname = TRIM(Agrif_CFixed())//"_"//TRIM(clname)
---
> !FUS            IF( jn == 1 .AND. TRIM(Agrif_CFixed()) /= '0' )   clname = TRIM(Agrif_CFixed())//"_"//TRIM(clname)
> !FUS see comment line 700
>             IF( jn == 1 .AND. TRIM(Agrif_CFixed()) /= '0' ) THEN
>              iln    = INDEX(clname,'/',BACK=.true.)
>              cltmpn = clname(1:iln)
>              clname = clname(iln+1:LEN_TRIM(clname))
>              clname = TRIM(cltmpn)//TRIM(Agrif_CFixed())//'_'//TRIM(clname)
>             ENDIF
> !FUS

Analysis


Recommendation

FUS to assess the necessity for these changes and to port to the option 1 branch if required.

Commit History (0)

(No commits)

Change History (3)

comment:1 Changed 22 months ago by clevy

  • Version changed from release-4.0 to release-4.0-HEAD

comment:2 Changed 22 months ago by clevy

  • Version changed from release-4.0-HEAD to 4.0-HEAD

comment:3 Changed 14 months ago by mathiot

  • Resolution set to wontfix
  • Status changed from new to closed
  • Version 4.0-HEAD deleted

Ticket related to the differences between branch option 1 and option 2 of merge 2019. As we are at the 2020 merge, I close the ticket.

Note: See TracTickets for help on using tickets.