Opened 7 months ago

Closed 5 months ago

#2391 closed Defect (fixed)

wrong default definition in namelist_pisces_ref

Reported by: smasson Owned by: systeam
Priority: low Milestone:
Component: PISCES Version: trunk
Severity: minor Keywords:
Cc:

Description

Context

in the bloc nampisbc of namelist_pisces_ref, the following logicals are defined to true by default:

   ln_ironsed  =  .true.   ! boolean for Fe input from sediments
   ln_ironice  =  .true.   ! boolean for Fe input from sea ice
   ln_hydrofe  =  .true.   ! boolean for from hydrothermal vents

They are associated to input data read with fldread. By default, the information use to read these data is:

   sn_dust     = 'dust.orca'       ,     -1            , 'dust'        ,  .true.      , .true. , 'yearly'  , ''       , ''    , ''
   sn_ironsed  = 'bathy.orca'      ,    -12            , 'bathy'       ,  .false.     , .true. , 'yearly'  , ''       , ''    , ''
   sn_hydrofe  = 'hydrofe.orca'    ,    -12            , 'epsdb'       ,  .false.     , .true. , 'yearly'  , ''       , ''    , ''

Analysis

⇒ by default, when using PISCES, we need the input files dust.orca, bathy.orca and hydrofe.orca… whatever configuration or test we do (such as BENCH…)

Recommendation

Could we either :

  • define these logical to false by default
  • keep them to true but define the file names as "NOT USED" so fldread will not try to read them. In this case a devault value of the data should also be added so the code would properly run even if we don't read any file.

Commit History (1)

ChangesetAuthorTimeChangeLog
12845cetlod2020-05-01T13:11:27+02:00

Change TOP & PISCES namelist parameter as we need the new input files, see ticket #2391

Change History (2)

comment:1 Changed 5 months ago by cetlod

In 12845:

Change TOP & PISCES namelist parameter as we need the new input files, see ticket #2391

comment:2 Changed 5 months ago by cetlod

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.