compilation of the tools fails in 4.0-HEAD

[clem]

In nemo 4.0-HEAD, compilation of the tools fails because of a missing file in mk (Fmake_tools_bld.sh). See message below

./maketools: line 155: /gpfswork/rech/omr/romr008/NEMO4/release-4.0-HEAD/mk/Fmake_tools_bld.sh: No such file or directory

Just adding the Fmake file does the job but since mk is tagged for this nemo revision, I do not know how to correct it.

[mathiot]

Crap, I think the root source of this error comes from the externals:

• During the last merge, changes in mk/maketools has been made to enable pre-processing in tools if a cpp_XXXXX.fcm file is specified.
• For mk, there is no trouble because the external is managed in the release directory. We can specify a different revision of 'mk' for each release/branch and in 4.0.2. So 'mk' revision is correct.
• For maketools, the external responsible for the checkout of 'maketools' is managed in tools itself, so it is not possible to specify a different revision of 'maketools' between trunk, releases and branches.

For me, the trouble comes from the management of the external revision in tools, not from 'maketools' or 'mk'. In NEMO (releases/* trunk/ branches/*) we have 'external of external' (ie NEMO has tools as external and tools has maketools as external).

How to fix it now:

• We create a copy of tools (tools_4.0-HEAD ?) with a fix external revision for maketools and change the external definition in NEMO_4.0-HEAD to point to tools_4.0-HEAD.
• Update the external in 4.0-HEAD of 'mk' to 12415. I have success to compile REBUILD_NEMO with this technics. This is virtually the same solution as Clem suggested in his ticket.

To avoid this trouble again in the future:

• Avoid 'external of external'. For tools, it means reintegrate maketools in tools. For other part of the code, do we have other cases like this in doc, AGRIF ... ?
• Make sure before committing changes on 'external of external' that the external definition is properly set (ie not to the head). For tools it means when we change maketools in 'build/maketools' we have to change external definition in 'tools/'. I am not convinced this is a good solution.

[mathiot]

Action decided at 19th March St meeting to answer this ticket and prepare ground for other bug in tools for version 4 (#2413 for example):

• maketools have to be moved from utils/build to utils/tools/ and the externals definition in tools removed.

• creation of tools_r4.0-HEAD (copy of tools@12273 as specified in the externals for version 4), add the maketools file @12273 in tools_r4.0-HEAD and remove the externals definition in tools_r4.0-HEAD.

• change the externals in r4.0-HEAD to point toward tools_r4.0-HEAD instead of trunk

[mathiot]

In 12670:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 12671:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 12672:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 12673:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 12674:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 12676:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 12681:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

In 12683:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[mathiot]

Action 5 of https://forge.ipsl.jussieu.fr/nemo/wiki/SystemTeam/Agenda/2020-03-19 done in r12681 (trunk) and r12673 (r4.0-HEAD)