Opened 5 months ago

Closed 5 months ago

#2446 closed Bug (fixed)

ln_vorlat bug: fmask calculation

Reported by: jcastill Owned by: ayoung
Priority: low Milestone: 2020 WP
Component: DYN Version: 4.0-HEAD
Severity: minor Keywords: ln_vorlat vorticity acvection
Cc: davestorkey, mathiot, gm

Description

Context

It appears to be a bug in the initialization of tracer advection, in the calculation of fmask when ln_vorlat=.true.. I realized this not by looking at model output but at the logic of the code, so I do not know how it will influence model results.

Analysis

In the file dynvor.F90, the lines:

                 IF(    tmask(ji,jj+1,jk) + tmask(ji+1,jj+1,jk)              &
                     & + tmask(ji,jj  ,jk) + tmask(ji+1,jj+1,jk) == 3._wp )   fmask(ji,jj,jk) = 1._wp

seem to be wrong.

Fix

The previous lines should be substituted by:

                 IF(    tmask(ji,jj+1,jk) + tmask(ji+1,jj   ,jk)              &
                     & + tmask(ji,jj  ,jk) + tmask(ji+1,jj+1,jk) == 3._wp )   fmask(ji,jj,jk) = 1._wp

Commit History (1)

ChangesetAuthorTimeChangeLog
12792smasson2020-04-22T12:39:09+02:00

r4.0-HEAD: fixe minor bug in dynvor, see #2446

Change History (3)

comment:1 Changed 5 months ago by jcastill

  • Component changed from TOP to DYN

comment:2 Changed 5 months ago by smasson

In 12792:

r4.0-HEAD: fixe minor bug in dynvor, see #2446

comment:3 Changed 5 months ago by smasson

  • Resolution set to fixed
  • Status changed from new to closed

fixed in [12792]

Note: See TracTickets for help on using tickets.