Opened 4 years ago
Closed 4 years ago
#2471 closed Bug (fixed)
AGRIF_DEMO crash
| Reported by: | rblod | Owned by: | systeam |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | AGRIF | Version: | v4.0.* |
| Severity: | minor | Keywords: | |
| Cc: | smasson |
Description
Context
AGRIF_DEMO without any modifications crashes at initialization of the coarser grid, in version trunk r12984
Analysis
istate is calling div_hor, which is calling sbc_rnf_div if ln_rnf is TRUE. But at this point, ln_rnf is unknown (namsbc not read yet). If its default value is TRUE, sbc_rnf_div is called and use arrays like h_rnf which are not allocated yet.
It happens here with Agrif, but it can happen without, depending on compiler, optimisation level and so
Fix
A bit early morning for me to provide a proper solution. A recommandation could be to investigate why it was not catch by sette.
Commit History (2)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 13101 | rblod | 2020-06-12T13:10:44+02:00 | ticket #2471 : not need for initialisation of hdiv in istate.F90 |
| 13100 | rblod | 2020-06-12T13:06:47+02:00 | ticket #2471 : not need for initialisation of hdiv in istate.F90 |
Change History (5)
comment:1 Changed 4 years ago by rblod
comment:2 Changed 4 years ago by smasson
- Cc smasson added
I thought to modify div_hor to avoid to call sbc_rnf_div
IF( ln_rnf .and. kt > 0 ) CALL sbc_rnf_div( hdiv, Kmm ) !== runoffs ==! (update hdiv field)
comment:3 Changed 4 years ago by rblod
In 13100:
comment:4 Changed 4 years ago by rblod
In 13101:
comment:5 Changed 4 years ago by rblod
- Resolution set to fixed
- Status changed from new to closed
the call to div_hor in istate may no be necessary anymore and should simply be suppressed. I test on CMEMS branch and fix the trunk if ok