Opened 8 weeks ago

Last modified 5 weeks ago

#2488 new Defect

Inflexible calendar year and approximate conversion in option 2 of the freshwater-budget adjustment mechanism

Reported by: smueller Owned by: systeam
Priority: low Milestone:
Component: SBC Version: trunk
Severity: minor Keywords: fwb, SBC
Cc:

Description

Context

The defect described in ticket #2487 is also present in the current trunk version of NEMO.

Analysis

See ticket #2487.

Recommendation

After substitution of rdt by rn_Dt and rau0 by rho0, the modifications recommended in ticket #2487 should be suitable for removing this defect from the current trunk version of NEMO.

Commit History (1)

ChangesetAuthorTimeChangeLog
13170smueller2020-06-29T12:02:22+02:00

Inception of a branch associated with ticket #2488

Change History (5)

comment:1 Changed 8 weeks ago by smueller

The modification of source:/NEMO/trunk/src/OCE/SBC/sbcfwb.F90@13098 which corresponds to the modification of source:/NEMO/releases/r4.0/r4.0-HEAD/src/OCE/SBC/sbcfwb.F90@13098 presented in comment:1:ticket:2487 is:

  • src/OCE/SBC/sbcfwb.F90

     
    123123            IF(lwp)WRITE(numout,*)'sbc_fwb : year = ',iyear  , ' freshwater budget correction = ', fwfold 
    124124            IF(lwp)WRITE(numout,*)'          year = ',iyear-1, ' freshwater budget read       = ', a_fwb 
    125125            IF(lwp)WRITE(numout,*)'          year = ',iyear-2, ' freshwater budget read       = ', a_fwb_b 
    126          ENDIF    
    127          !                                         ! Update fwfold if new year start 
    128          ikty = 365 * 86400 / rn_Dt                  !!bug  use of 365 days leap year or 360d year !!!!!!! 
    129          IF( MOD( kt, ikty ) == 0 ) THEN 
     126         ELSEIF( ( nday_year == 1 ) .AND. ( nsec_day == NINT( 0.5_wp * rn_Dt ) ) ) THEN   ! Update fwfold at the start of 1 January 
    130127            a_fwb_b = a_fwb                           ! mean sea level taking into account the ice+snow 
    131128                                                      ! sum over the global domain 
    132129            a_fwb   = glob_sum( 'sbcfwb', e1e2t(:,:) * ( ssh(:,:,Kmm) + snwice_mass(:,:) * r1_rho0 ) ) 
    133             a_fwb   = a_fwb * 1.e+3 / ( area * rday * 365. )     ! convert in Kg/m3/s = mm/s 
    134 !!gm        !                                                      !!bug 365d year  
     130            a_fwb   = a_fwb * rho0 / ( area * rday * nyear_len(1) )     ! convert into kg/m3/s 
    135131            fwfold =  a_fwb                           ! current year freshwater budget correction 
    136132            !                                         ! estimate from the previous year budget 
    137133         ENDIF 

comment:2 Changed 5 weeks ago by smueller

See ticket:2487#comment:2; it also applies to ticket #2488 after substitution of sshn, sshb, and r1_rau0 by ssh(:,:,Kmm), ssh(:,:,Kbb), and r1_rho0, respectively.

comment:3 Changed 5 weeks ago by smueller

In 13170:

Inception of a branch associated with ticket #2488

comment:4 Changed 5 weeks ago by smueller

See ticket:2487#comment:4, which also applies to ticket #2488 after substitution of e3t_n(:,:,jk), e3t_b(:,:,jk), sshn(:,:), and sshb(:,:) by e3t(:,:,jk,Kmm), e3t(:,:,jk,Kbb), ssh(:,:,Kmm), and ssh(:,:,Kbb), respectively.

Last edited 5 weeks ago by smueller (previous) (diff)

comment:5 Changed 5 weeks ago by smueller

The discussion with Gurvan and Seb in the context of tickets #2487 and #2488 also resulted in the recommendation to remove options nn_fwb = 1 and nn_fwb = 3 of the freshwater-budget adjustment mechanism from the trunk version of NEMO.

Note: See TracTickets for help on using tickets.