Opened 3 years ago
Last modified 3 years ago
#2503 new Bug
DOMcfg: careful review/cleaning needed after r13204
Reported by: | mathiot | Owned by: | systeam |
---|---|---|---|
Priority: | low | Milestone: | Unscheduled |
Component: | tools | Version: | trunk |
Severity: | major | Keywords: | DOMAINcfg, |
Cc: |
Description
Context
Work to have DOMcfg compatible with Agrif has been added in r13204. In the mean time:
- useless files came up with (MODEL.*, Makefile*, make.inc, sfmakedepend and maybe some other). This files are no more needed even with Agrif as a preprocessing step has been added last year. (cosmetic as long as you don't try to use it, I didn't test these files)
- in dom_oce : variable allocation removed last year as part of acleaning came up as commented fields. If they are useless they should be removed. (cosmetic)
- dom_clo has been commented and moved up (before dommsk). So even if uncommented, it will not work because ssmask is not known yet and why commented it ? If the option is not work, we should fix it not comment it. (functionality broken)
- others ? (I didn't do an extensive check of all the changes in the non-agrif part)
Analysis
It looks to me difficulties to merge a work baed on an old revision of the tools to the new version (commit r13024 in a branch) and then it propagate to the trunk of tools.
Suggestion
There is still work on-going with AGRIF, so it could be worth :
- waiting this to be done and then do a proper cleaning.
- adding a testing strategy for tools to avoid broken functionality for tools: especially REBUILD_NEMO and DOMAINcfg (need to test also reproducibility across various decomposition too).
- in the mean time maybe implement #2500 or part of it.
Commit History (0)
(No commits)
Note: See
TracTickets for help on using
tickets.
In addition to the list mentioned above:
These changes occurs at the same time as the changes mentioned above.