Opened 3 months ago

Closed 3 months ago

#2510 closed Bug (fixed)

out of bound in dtadyn.F90

Reported by: mathiot Owned by: mathiot
Priority: low Milestone:
Component: OFF Version: trunk
Severity: major Keywords: OFF,
Cc:

Description

Context

SETTE tests on the trunk failed on UGA cluster. The failed occurs during the mid year merge.

Analysis

After running sette in debug mode, it appears there is an out of bound in dtadyn.F90. The use of jf_ubl and jf_vbl need to be protected by ln_trabbl.

Fix

  • src/OFF/dtadyn.F90

     
    295295      CALL fld_fill( sf_dyn, slf_d, cn_dir, 'dta_dyn_init', 'Data in file', 'namdta_dyn' ) 
    296296      sf_dyn(jf_uwd)%cltype = 'U'   ;   sf_dyn(jf_uwd)%zsgn = -1._wp   
    297297      sf_dyn(jf_vwd)%cltype = 'V'   ;   sf_dyn(jf_vwd)%zsgn = -1._wp   
    298       sf_dyn(jf_ubl)%cltype = 'U'   ;   sf_dyn(jf_ubl)%zsgn =  1._wp   
    299       sf_dyn(jf_vbl)%cltype = 'V'   ;   sf_dyn(jf_vbl)%zsgn =  1._wp   
    300298      ! 
     299      IF( ln_trabbl ) THEN 
     300         sf_dyn(jf_ubl)%cltype = 'U'   ;   sf_dyn(jf_ubl)%zsgn =  1._wp   
     301         sf_dyn(jf_vbl)%cltype = 'V'   ;   sf_dyn(jf_vbl)%zsgn =  1._wp   
     302      END IF 
     303      ! 
    301304      ! Open file for each variable to get his number of dimension 
    302305      DO ifpr = 1, jfld 
    303306         CALL fld_def( sf_dyn(ifpr) ) 

How to avoid

  • short term: for every important merge: run sette with debug mode few time step
  • long term: fix sette to do it automatically

Commit History (1)

ChangesetAuthorTimeChangeLog
13377mathiot2020-08-05T17:15:35+02:00

ticket #2510: fix out of bound in dtadyn.F90

Change History (2)

comment:1 Changed 3 months ago by mathiot

In 13377:

ticket #2510: fix out of bound in dtadyn.F90

comment:2 Changed 3 months ago by mathiot

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.