MY_SRC of ISOMIP+

[smasson]

Context

The MY_SRC of ISOMIP+ contains many duplicated routines that have not been correctly phased with their src equivalent.
For example, the Current version is not compliant with the new definition of gdept in domzgr_substitute.
It does not pass sette tests in debug mode.

Analysis

The duplication of routines has been introduced in NEMO with the MY_SRC directories and the use of different src/* directories but this is ALWAYS a bad solution. I am spending days phasing duplicated routines that are always forgotten either by the developers or during the svn merge procedure...

Recommendation

We must avoid duplicated routines.
For example in this case I don't understand why there is duplicated eosbn2, why proper nameliste parameters of ln_seos cannot give the same results as ln_eos?
Why istate, dtatsd are duplicated? We should adapt the original routines instead of duplicating routines.

[mathiot]

On the general issue:

• I agree on the main idea, the less there is in MY_SRC for the test cases (or others), the better it is (less file to maintain).

On this specific case:

• ticket has been open with suggestion to give more freedom in the configuration design (#2540, #2539, #2538) which are responsible for some of these files.

[mathiot]

In 13583:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found