Opened 8 weeks ago

Last modified 7 weeks ago

#2536 new Defect

MY_SRC of ISOMIP+

Reported by: smasson Owned by: systeam
Priority: low Milestone:
Component: MULTIPLE Version: trunk
Severity: minor Keywords:
Cc:

Description

Context

The MY_SRC of ISOMIP+ contains many duplicated routines that have not been correctly phased with their src equivalent.
For example, the Current version is not compliant with the new definition of gdept in domzgr_substitute.
It does not pass sette tests in debug mode.

Analysis

The duplication of routines has been introduced in NEMO with the MY_SRC directories and the use of different src/* directories but this is ALWAYS a bad solution. I am spending days phasing duplicated routines that are always forgotten either by the developers or during the svn merge procedure…

Recommendation

We must avoid duplicated routines.
For example in this case I don't understand why there is duplicated eosbn2, why proper nameliste parameters of ln_seos cannot give the same results as ln_eos?
Why istate, dtatsd are duplicated? We should adapt the original routines instead of duplicating routines.

Commit History (1)

ChangesetAuthorTimeChangeLog
13583mathiot2020-10-09T14:04:13+02:00

ticket #2535: change for ISOMIP+ to pass sette (for root cause see #2536)

Change History (2)

comment:1 Changed 7 weeks ago by mathiot

On the general issue:

  • I agree on the main idea, the less there is in MY_SRC for the test cases (or others), the better it is (less file to maintain).

On this specific case:

  • ticket has been open with suggestion to give more freedom in the configuration design (#2540, #2539, #2538) which are responsible for some of these files.

comment:2 Changed 7 weeks ago by mathiot

In 13583:

ticket #2535: change for ISOMIP+ to pass sette (for root cause see #2536)

Note: See TracTickets for help on using tickets.