Opened 4 years ago
Closed 4 years ago
#2555 closed Defect (fixed)
Proper fix for ENE and ENS in partial step
Reported by: | techene | Owned by: | techene |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | DYN | Version: | trunk |
Severity: | minor | Keywords: | dynvor, dynldf |
Cc: |
Description (last modified by techene)
Status
There are two issues to solve in NEMO/OCE/DYN :
1° In dynvor.F90 there is an ugly fix to avoid a crash when using ENE or ENS vorticity schemes in partial cell case. The fix is to remove vertical scale factor (e3f/u/v) in the vorticity term.
This fix stabilises the model but breacks the kinetic energy conservation (for ENE) and potential enstrophy conservation (for ENS).
2° (UNSTABLE : STICK TO 1° ONLY) In dynldf_lap_blp.F90 when using EEN scheme the e3f used in dynldf is not the one used in dynvor.
Proper fix
1° use in ENE and ENS the same definition of e3f scale factor as in EEN.
2° (UNSTABLE : STICK TO 1° ONLY) use the same scale factor in both dynldf and dynvor.
This development is to be included in KERNEL-06 action. It changes the results for sette tests using ENE or ENS.
Wikipage: wiki:2020WP/KERNEL-06_techene_better_e3_management
Commit History (5)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
13706 | techene | 2020-10-29T15:51:55+01:00 | #2385 #2555 and #2527 shallow water test case now runs properly |
13705 | techene | 2020-10-29T15:46:15+01:00 | #2555 nn_een_e3f parameter no longer controls EEN e3f computation only it also controls ENE and ENS e3f then is has been turned into nn_e3f_typ |
13704 | techene | 2020-10-29T15:34:05+01:00 | #2555 nn_een_e3f parameter no longer controls EEN e3f computation only it also controls ENE and ENS e3f then is has been turned into nn_e3f_typ |
13703 | techene | 2020-10-29T15:29:09+01:00 | #2555 remove nn_een_e3f parameter from name list this parameter is now used for EEN, ENE and ENS vorticity schemes then its name is turned into nn_e3f_typ |
13696 | techene | 2020-10-28T19:09:27+01:00 | #2555 use same e3f definition as in EEN in ENS and ENE instead of previous ugly fix and change time splitting accordingly change namelist vorticity scheme param nn_een_e3f into nn_e3f_typ |
Change History (7)
comment:1 Changed 4 years ago by techene
comment:2 Changed 4 years ago by techene
In 13703:
comment:3 Changed 4 years ago by techene
In 13704:
comment:4 Changed 4 years ago by techene
In 13705:
comment:5 Changed 4 years ago by techene
In 13706:
comment:6 Changed 4 years ago by techene
- Owner set to techene
- Status changed from new to assigned
comment:7 Changed 4 years ago by techene
- Description modified (diff)
- Milestone Unscheduled deleted
- Resolution set to fixed
- Status changed from assigned to closed
In 13696: