typo bug in sea ice with large consequences (from revision 4.0.4)

[clem]

Context

I introduced a nasty bug between release 4.0.3 and 4.0.4
It's a typo that changed drastically the distribution of solar and non-solar fluxes over ice covered areas. As a consequence, the ice cover and volume increased and some processes had wrong seasonality. In particular the lateral melting.

Since this bug has been introduced while correcting other bugs, and given the importance of it on the ice simulations, I feel uncomfortable keeping the last revision 4.0.5 untouched. Fortunately the official announcement of this revision has not yet been done.

So, I wonder if I could erase the current 4.0.5 and redo it. I know it is not the way we should work but I do not want people to use this version and not be aware of that. What say you?

Besides documentation, here are the only changes in 4.0-HEAD vs 4.0.5:
NEMO/releases/r4.0/r4.0-HEAD@14359:14435
It concerns a bug fix in iceberg module (ticket #2581) and a small incompatibility oasis-agrif (ticket #2621)

Fix

in iceupdate.F90, replace this line:

            qns(ji,jj) = qt_oce_ai(ji,jj) - zqsr

by this one:

            qns(ji,jj) = qt_oce_ai(ji,jj) - qsr(ji,jj)

[nicolasmartin]

Well, I'm not in the best position to decide what should be done but this kind of situation is going to reproduce quite often as we have speed up our release timeline.

Diff r4.0.5/r4.0-HEAD
Diff r4.0.4/r4.0.5

As you wrote, the changes are so small but so significant that we can consider replacing the current version of r4.0.5 release.

[clem]

In 14469:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[clem]

In 14470:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[jpalmier]

In 14472:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found